-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCH Editor Sidebar: Fix incorrect AI opt-in message #2296
PCH Editor Sidebar: Fix incorrect AI opt-in message #2296
Conversation
src/RemoteAPI/content-suggestions/class-content-suggestions-base-api.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for working of this! I added a comment that's not directly about your changes, but since we're touching this component, I think it makes sense to update it now.
@vaurdan, will do, thanks 🙂 |
@vaurdan, most of the CSS is still relevant (only removed one line). I agree with you that we might need to improve and move it probably somewhere else. Since moving it though would need some additional testing, I prefer to leave as-is for now and tackle it in a different PR, since we want to release this improvement tomorrow. That PR would be about errors and the Contact Us message which is considered as an error but isn't. I'd want to make sure there are no clashes happening between the message, the errors, and different parts of the PCH (Sidebar, Dashboard Widget). Are you OK with that? If yes, let's merge this as-is for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! Approved 🙂
Description
An incorrect message was being displayed in the PCH Editor Sidebar for opting into AI features. This PR fixes this by displaying the correct message and also improves the notice's styling which has some display issues.
Motivation and context
The messages we show should be relevant.
How has this been tested?
Screenshots