PCH: Fix some untranslatable strings #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vaurdan, on second pass, these strings seem a bit incorrect and would need to be updated? |
|
How about updating the string to "Settings"? |
|
Yeah, they are definitely incorrect. Those are some left-over strings from when I was experimenting with the component before the final implementation. Changing them to |
vaurdan
reviewed
Mar 26, 2024
src/content-helper/editor-sidebar/performance-details/component-panel.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/editor-sidebar/performance-details/component-panel.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Henrique Mouta <henrique@automattic.com>
vaurdan
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of strings that couldn't be translated, so they are translatable now.
Motivation and context
All our strings should be translatable.
How has this been tested?
Untested.