"Critical Time" and "SLA violation countdown" performance counters should be optional

[johnsimons]

Performance counters are now opt-in to avoid issues with setting them up preventing users from getting their endpoints to run in production

Breaking change

Previous versions enabled the performance counters Critical Time and SLA violation countdown by default. To get the same behavior with the 6.0 host you need to either:

1. Use the profile NServiceBus.PerformanceCounters - More on profiles here
2. Explicitly enable the counters in code using:

config.EnableCriticalTimePerformanceCounter();
config.EnableSLAPerformanceCounter();   

Problem

In v5.0 the default production profile enables by default "Critical Time" and "SLA violation countdown" performance counters.
Users cannot turn this off easily.

[andreasohlund]

Breaking change, bumping to 6.0.0

[johnsimons]

@yvesgoeleven you asked about this on hipchat, at the moment there is no nice way, you need to use a non production profile

[johnsimons]

@Particular/core-developers we should fix this and release v6 soon.
Anyone against it?

[andreasohlund]

I'm +1. So is the fix to deprecate/remove the PerformanceCounter profile or
just not inherit the production profile from it?

I suggest the first option.

On Thu, Nov 13, 2014 at 4:55 AM, John Simons notifications@github.com
wrote:

@Particular/core-developers
https://github.com/orgs/Particular/teams/core-developers we should fix
this and release v6 soon.
Anyone against it?

—
Reply to this email directly or view it on GitHub
#26 (comment)
.