Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Custom logging override still produces default log file #29

Closed
SimonCropp opened this issue Nov 20, 2014 · 8 comments
Closed

Custom logging override still produces default log file #29

SimonCropp opened this issue Nov 20, 2014 · 8 comments

Comments

@SimonCropp
Copy link
Contributor

When a user overrides logging to use a custom one, the host override is too late and the default log still executes creating a default log file with at least 2 INFO entries in it.

This occurs because INFO is the default level.

A solution is to ensure all logging entries before the user can override are below the default INFO level.

Raised by @johnsimons
Migrated from by Particular/NServiceBus#2574

@SimonCropp
Copy link
Contributor Author

what happens if an error occurs before we get to the users custom override?
Raised by @SimonCropp

@SimonCropp
Copy link
Contributor Author

We back to square one 😞
Raised by @johnsimons

@SimonCropp
Copy link
Contributor Author

How about we add a magic appSettings key that allows the user to specify a type that will be called as early as possible by our host to setup logging ?
Raised by @johnsimons

@johnsimons
Copy link
Member

@SimonCropp v6 of the host is ready to go out, should we wait for this fix too?

@johnsimons johnsimons modified the milestone: 5.1.0 Nov 20, 2014
@SimonCropp
Copy link
Contributor Author

@johnsimons i dont have an opinion

@SimonCropp
Copy link
Contributor Author

@johnsimons so how was "an error occurring before we got to the users custom logging" handled in v4?

@johnsimons
Copy link
Member

no idea @SimonCropp

@johnsimons johnsimons added the Bug label Nov 21, 2014
@johnsimons johnsimons added this to the 6.0.0 milestone Nov 21, 2014
@johnsimons johnsimons self-assigned this Nov 21, 2014
@johnsimons
Copy link
Member

Fixed in 3778f7d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants