Clears previous timeout when copying #2312
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that only one timeout is active for hiding the "copied" tooltip, preventing potential issues when copying multiple times in quick succession. This is achieved by clearing any existing timeout before setting a new one.
|
where did you source this best practice from? Connect the dots for future reviewers |
PhilBastian
approved these changes
Apr 6, 2025
|
This came mostly from reading the docs about side effects - https://vuejs.org/guide/essentials/watchers.html#side-effect-cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement, it seems using a watcher is a better way to clearing previous timeouts