Fixing typescript typings #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added debounce for filter component
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PhilBastian
reviewed
Apr 7, 2025
| const props = withDefaults(defineProps<{ placeholder?: string; ariaLabel?: string }>(), { placeholder: "Filter by name...", ariaLabel: "filter by name" }); | ||
| const localInput = ref<string>(model.value); | ||
| const debounceUpdateModel = debounce((value: string) => { |
There was a problem hiding this comment.
I think including a library dependency for this functionality is overkill
There was a problem hiding this comment.
Well, are you proposing we reinvent the wheel?
There was a problem hiding this comment.
yes, for something as simple as a setTimeout, it is safer to reinvent the wheel rather than pull in a library
PhilBastian
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added debounce for filter component