-
Notifications
You must be signed in to change notification settings - Fork 26
Sequence Diagram tooltips #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/Frontend/src/components/messages/SequenceDiagram/RoutesComponent.vue
# Conflicts: # src/Frontend/src/components/messages/SequenceDiagram/EndpointsComponent.vue # src/Frontend/src/components/messages/SequenceDiagram/HandlersComponent.vue # src/Frontend/src/components/messages/SequenceDiagram/RoutesComponent.vue # src/Frontend/src/resources/SequenceDiagram/RoutedMessage.ts # src/Frontend/src/stores/SequenceDiagramStore.ts
# Conflicts: # src/Frontend/src/components/messages/SequenceDiagram/EndpointsComponent.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So are these tooltips added to the dom all the time or just on demand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you took the hard way https://vue-tippy.netlify.app/flavor/composition-api 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added only on mouseover after the specified delay
I don't understand what you mean by hard way? The linked page is what I used as the guide to my final solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the advanced way
function formatTime(milliseconds: number) { | ||
const time = useFormatTime(milliseconds); | ||
return `${time.value} ${time.unit}`; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a component that is reused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could use it in the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and probably other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an idea card
Implement tooltips as per ServiceInsight and integrate with new message view/message store