Refactor SagaDiagram and tests to use new toLocalDateTimeString utility #2475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilBastian
reviewed
Jun 19, 2025
PhilBastian
approved these changes
Jun 19, 2025
Removing the need to test too close to the implementation
cquirosj
reviewed
Jun 19, 2025
cquirosj
reviewed
Jun 19, 2025
Saga localization tests fix: Retrieve UI date strings and convert to date values for performing assertions
cquirosj
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a utility function,
toLocalDateTimeString, to standardize the formatting of date-time strings. The function is currently used only in theSagaDiagramcomponent and its associated tests, as this is the only area in the system where date-time values were formatted in this specific way.While the utility was designed with reuse in mind, no other components were found to use this pattern, so no further updates were made.