Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Conversation

cittyinthecloud
Copy link
Contributor

This keeps stack traces resulting from unimplemented classes and members from being full of confusing Mixin and class loading errors.

@rikka0w0
Copy link
Contributor

I would like to suggest that we should include a link for the users to submit their issue, for example, the github issue page.

@florensie
Copy link
Member

Maybe check if the class/method/field is actually in the forge package?

@kitlith
Copy link
Contributor

kitlith commented Jul 22, 2020

Forge adds methods and fields to vanilla classes, too, @florensie

@florensie
Copy link
Member

@kitlith Fair but what if it's something else like a class missing in a dependency mod. I guess it might be too much effort to check every package forge touches.

@kitlith
Copy link
Contributor

kitlith commented Jul 22, 2020

@florensie we could limit to net.minecraftforge and net.minecraft then? That's still not perfect if a mod adds a class under net.minecraft to access package private things, but it's something.

@TheGlitch76
Copy link
Member

TheGlitch76 commented Jul 30, 2020

We don't let mods add things under the net.minecraft package, yet

Copy link
Member

@TheGlitch76 TheGlitch76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good concept, but I'd like to see one change:
If the NCD is under net.minecraft or net.minecraftforge, have the error be "an unimplemented class", but if it's under another package have the error be "a missing and undeclared dependency"

@TheGlitch76 TheGlitch76 merged commit e92de09 into master Jul 30, 2020
@TheGlitch76 TheGlitch76 deleted the better-unimplemented-traces branch July 30, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants