This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Rename patchwork-client-colors to patchwork-events-rendering and implement TextureStitchEvent #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to impl the IModelLoader and IModelGeometry once I finish my custom registery impl |
coderbot16
suggested changes
Jun 15, 2020
...hwork-events-rendering/src/main/java/net/minecraftforge/client/event/TextureStitchEvent.java
Outdated
Show resolved
Hide resolved
...hwork-events-rendering/src/main/java/net/minecraftforge/client/event/TextureStitchEvent.java
Outdated
Show resolved
Hide resolved
...hwork-events-rendering/src/main/java/net/minecraftforge/client/event/TextureStitchEvent.java
Outdated
Show resolved
Hide resolved
...ents-rendering/src/main/java/net/patchworkmc/mixin/event/render/MixinSpriteAtlasTexture.java
Outdated
Show resolved
Hide resolved
coderbot16
approved these changes
Jun 16, 2020
...hwork-events-rendering/src/main/java/net/minecraftforge/client/event/TextureStitchEvent.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the Discord, the rename is to have one module for things like colors, model baking, etc. I've implemented TextureStitchEvent, but someone who understands rendering better than me should probably implement model loading and the bake event.