Allow ws options to be passed to constructors #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This complies with the way ws behaves and is useful for specifying "low-level" ws options such as adding additional headers to the request (use case: authentication through jwt)
|
@clinoge, good addition, thanks for making the contribution. Does anyone know when this might be merged? |
|
👍 |
|
@gdi2290 Do you know if anything is blocking this merge and release? |
|
@clinoge Can you update the readme and changelog for this feature? |
|
@clinoge How would I add the header to the connection string? var wsTransactions = $websocket('wss://URL:8090/access/transactions', {
reconnectIfNotNormalClose: true
}); |
|
bump |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complies with the way ws behaves and is
useful for specifying "low-level" ws options
such as adding additional headers to the
request (use case: authentication through jwt).
No breaking changes have been done by this commit.