Skip to content

Fix validation #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 28, 2022
Merged

Fix validation #1071

merged 6 commits into from
Sep 28, 2022

Conversation

thet
Copy link
Member

@thet thet commented Sep 27, 2022

thet added 4 commits September 28, 2022 11:03
@thet
maint(pat date picker): Use logging framework instead of console.log.
e35932f
@thet
feat(pat date picker): Improve pat-validation integration.
57c974b 
Allow pat-validate to check for validity when date picker was interacted with
but no value selected.
@thet
feat(pat auto suggest): Improve pat-validation integration.
11e9a0b 
Allow pat-validate to check for validity when select2 was interacted with but
no value selected.
@thet
feat(pat validation): Validate whole form on submit or single error.
bc27e41 
Validate the whole form when a single error happens and some elements were
disabled or when a form submit is done.
This gives the user a better feedback about any data problems in the
form and allows the user to see any other errors at all since the submit
elements could have been disabled and form validation would eventually
not be triggered.
@thet thet merged commit 065e37f into master Sep 28, 2022
@thet thet deleted the fix-validation branch September 28, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thet