Skip to content

fix(pat-depends): Listen and dispatch input instead of change events. #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(pat-depends): Listen and dispatch input instead of change events. #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/pat/depends/depends.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,22 @@ class Pattern extends BasePattern {
this.set_state();

for (const input of this.handler.getAllInputs()) {
// Note: One input can be a dependency for multiple other dependent
// elements. Therefore we need to bind the events not uniquely and
// add a uuid to the event bindings id.

events.add_event_listener(
input,
"change",
`pat-depends--change--${this.uuid}`, // We need to support multiple events per dependant ...
this.set_state.bind(this)
);
events.add_event_listener(
input,
"keyup",
`pat-depends--keyup--${this.uuid}`, // ... therefore we need to add a uuid to the event id ...
"input",
`pat-depends--input--${this.uuid}`,
this.set_state.bind(this)
);

if (input.form) {
events.add_event_listener(
input.form,
"reset",
`pat-depends--reset--${this.uuid}`, // ... to not override previously set event handlers.
`pat-depends--reset--${this.uuid}`,
async () => {
// TODO: note sure, what this timeout is for.
await utils.timeout(50);
Expand All @@ -77,8 +75,9 @@ class Pattern extends BasePattern {
const inputs = dom.find_inputs(this.el);
for (const input of inputs) {
input.disabled = false;
// Trigger the change event after disabling so that any other bound actions can react on that.
input.dispatchEvent(events.change_event());
// Trigger the input after disabling so that any other bound
// actions can react on that.
input.dispatchEvent(events.input_event());
}
if (this.el.tagName === "A") {
events.remove_event_listener(this.el, "pat-depends--click");
Expand All @@ -96,8 +95,9 @@ class Pattern extends BasePattern {
const inputs = dom.find_inputs(this.el);
for (const input of inputs) {
input.disabled = true;
// Trigger the change event after disabling so that any other bound actions can react on that.
input.dispatchEvent(events.change_event());
// Trigger the input after disabling so that any other bound
// actions can react on that.
input.dispatchEvent(events.input_event());
}
if (this.el.tagName === "A") {
events.add_event_listener(this.el, "click", "pat-depends--click", (e) =>
Expand Down
6 changes: 3 additions & 3 deletions src/pat/depends/depends.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,9 @@ describe("pat-depends", function () {
const button2 = document.querySelector("[name=extra]");

button1.checked = true;
button1.dispatchEvent(new Event("change"));
button1.dispatchEvent(new Event("input"));
button2.checked = true;
button2.dispatchEvent(new Event("change"));
button2.dispatchEvent(new Event("input"));

expect(dom.is_visible(dep1)).toBe(true);
expect(dom.is_visible(dep2)).toBe(true);
Expand All @@ -250,7 +250,7 @@ describe("pat-depends", function () {
// Even though button2 is still checked, the visibility of dep2 is
// hidden.
button1.checked = false;
button1.dispatchEvent(new Event("change"));
button1.dispatchEvent(new Event("input"));

expect(dom.is_visible(dep1)).toBe(false);
expect(dom.is_visible(dep2)).toBe(false);
Expand Down
Loading