Fix pat depends #1232
Merged
Fix pat depends #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom.is_button tests, if an element is a button like element.
Button like elements are the following:
button,
button[type=button],
button[type=submit],
input[type=image],
input[type=button],
input[type=reset],
input[type=submit]
Fix some situations where infinite loops were created of unnecessary function calls were done: - Do not en/disable already en/disabled inputs. - Do not trigger and pat-depends element if the input is the element itself and not a contained sub-input. - Do not trigger input events on button-like elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(core dom): Add method is_button.
dom.is_button tests, if an element is a button like element.
Button like elements are the following:
fix(pat-depends): Fix infinite loop situations.
Fix some situations where infinite loops were created of unnecessary
function calls were done:
itself and not a contained sub-input.