Rebase URLs in pattern options. #790

thet · 2020-12-22T18:32:56Z

core parser, core mockup-parser, core base, core registry: modernize code
code dom: Make find_parents more robust against DocumentFragments with no parent.
core utils: Add jqToNode to return a DOM node if a jQuery node was passed
Fix tests: Add missing import for jquery-ext where it's needed.
pat autofocus: Avoid jQuery extended CSS selector syntax.
pat slides: Avoid jQuery extended CSS selector syntax.
pat inject: Rebase URLs in pattern options.

… more regular js

…hout a parent.

…ssed.

This avoids URLs in pattern configuration to point to unreachable paths in the context where the result is injected into.

We need to use the pattern's parser to be able to correctly parse the pattern configuration.

thet · 2020-12-23T15:17:45Z

This PR got quite massive!
It contains a number of micro-commits (i have the rule of one extra commit per pattern) PLUS it contains a lot of JS modernization in src/core (done on my trainride to vienna).

thet added 10 commits December 21, 2020 15:19

core parser: modernize code - simpler function definitions

cdb9292

core parser: modernize code - use arrow functions

91264e4

core parser: modernize code - let/const instead of var

3c08438

core parser: modernize code - class based syntax

a54e8ad

core parser: Remove usage of underscore.

dfbb547

core mockup-parser: modernize code

2a0e515

core base: modernize code

336f16d

core registry: modernize code

ee09d31

core registry: Modernize code - Remove underscore and jquery-ext, use…

b50415b

… more regular js

core registry scan: Clean up selectors before querying.

ce904bf

thet added the hold merge label Dec 22, 2020

thet force-pushed the thet-parser branch from b793fb3 to bd6d76a Compare December 22, 2020 19:07

thet added 5 commits December 23, 2020 15:14

code dom: Make find_parents more robust against DocumentFragments wit…

b2ecbec

…hout a parent.

core utils: Add jqToNode to return a DOM node if a jQuery node was pa…

d97881a

…ssed.

Fix tests: Add missing import for jquery-ext where it's needed.

06c1728

pat autofocus: Avoid jQuery extended CSS selector syntax.

6de0d64

pat slides: Avoid jQuery extended CSS selector syntax.

0a3fd54

thet force-pushed the thet-parser branch from bd6d76a to 1afb5f6 Compare December 23, 2020 14:56

thet added 10 commits December 23, 2020 16:15

pat inject: Rebase URLs in pattern configuration attributes.

e3036e9

This avoids URLs in pattern configuration to point to unreachable paths in the context where the result is injected into.

core base: Add the parser instance to pattern attributes if available.

9c8ef3b

pat inject: Rebase URLs in pattern configuration attributes /2

a2b5f88

We need to use the pattern's parser to be able to correctly parse the pattern configuration.

pat calendar: Add the parser to the pattern attributes.

1cff029

pat collapsible: Add the parser to the pattern attributes.

766ba67

pat date-picker: Add the parser to the pattern attributes.

a2d6f99

pat datetime-picker: Add the parser to the pattern attributes.

3a9d5e0

pat calendar demo: Fix url.

4708830

pat date-picker demo: Fix url.

772ed39

pat collapsible demo: Fix url.

4ae77ec

thet force-pushed the thet-parser branch from 1afb5f6 to 4ae77ec Compare December 23, 2020 15:15

thet removed the hold merge label Dec 23, 2020

thet merged commit 971199e into master Dec 23, 2020

thet deleted the thet-parser branch December 23, 2020 15:18

thet mentioned this pull request Apr 6, 2021

[archive] pat-inject: rebase options #825

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rebase URLs in pattern options. #790

Rebase URLs in pattern options. #790

Uh oh!

thet commented Dec 22, 2020

Uh oh!

thet commented Dec 23, 2020

Uh oh!

Uh oh!

Rebase URLs in pattern options. #790

Rebase URLs in pattern options. #790

Uh oh!

Conversation

thet commented Dec 22, 2020

Uh oh!

thet commented Dec 23, 2020

Uh oh!

Uh oh!