pat calendar: Support pat-tooltip #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat calendar: Support `url` in the event JSON model additionally to `@id`. The unique identifier is often not semantically correct for a URL to the item, especially when we want to call a specific view.
|
@cornae can we schedule a meeting tomorrow morning? I'm available from 08:30 on. |
|
Meeting with cornelis, the changes are OK. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pat calendar: Support
pat-tooltipon events with a URL viapat-tooltip-sourceset toajax.@cornae I gave this feature a second shot, as we need it for the absences app.
I followed your suggestion in https://github.com/quaive/ploneintranet.prototype/pull/1071#issuecomment-683847959 but implemented currently only
pat-tooltip-sourcewhich can be set to "ajax" as only possible value (content or anything else doesn't make sense I guess...).I did not implement
pat-tooltip-position-listor other options yet - I'll see how good the default positioning helps us with our requirement.@cornae I you need any other options, let me know