Skip to content

Conversation

rayk472
Copy link
Collaborator

@rayk472 rayk472 commented Jul 14, 2022

Branch cleaned up only lab04 on this branch

@brucestull brucestull self-requested a review July 14, 2022 16:11
@brucestull
Copy link
Collaborator

I think there might be some fundamental concept regarding git which we need to discuss.

I'll try to explain below but see me so we can discuss your process and help you understand what it means for files or file changes to be part of a branch. Please see me so we can figure out what's going on.

It's not clear to me where and when the labs were deleted to only have the Black Jack advice lab on this branch. One very difficult concept of git is that it tracks changes to files. Old labs will show up on new branches after those old labs have been graded and merged into branch main. That is normal and expected. When we say 'for a branch, only have changes to that specific lab on the branch', that means that the old labs can be part of the branch, just be aware that we shouldn't be making code changes to those old labs on the current branch.

@brucestull
Copy link
Collaborator

Let's get a breakout this evening.

I see you've already done Lab04 BlackJack Advice and it's on the main branch. Let's talk about this pull request to help you understand how old labs show up (as intended) on main branch and they are expected to be part of your new lab branches, BUT changes to the old labs is what shows up in pull requests. The things you are viewing in a pull request are the 'changes' to files. Your old labs are part of the new branch, they only become an issue if we make changes to them.

@brucestull brucestull requested review from nathanBonilla and removed request for brucestull and nathanBonilla July 15, 2022 22:38
@brucestull brucestull removed their assignment Jul 16, 2022
@nathanBonilla nathanBonilla requested review from nathanBonilla and removed request for nathanBonilla July 20, 2022 01:21
@nathanBonilla
Copy link
Contributor

Putting this PR on the back burner for now.

@nathanBonilla nathanBonilla marked this pull request as draft July 20, 2022 01:48
@rayk472 rayk472 marked this pull request as ready for review July 25, 2022 23:20
Copy link
Collaborator

@brucestull brucestull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blackjack Advice

Needs Work

Comments:

  • The black jack logic for advice seems that it may work properly. Will need to test further.
  • User should be prompted for input of the cards. It might be useful to tell the the user which cards are acceptible.
    • The assignment states the following:
    Let's write a python program to give basic blackjack playing advice during a game by asking the player for cards.
    First, ask the user for three playing cards (A, 2, 3, 4, 5, 6, 7, 8, 9, 10, J, Q, or K). 
    

@brucestull brucestull marked this pull request as draft July 26, 2022 01:39
@brucestull brucestull marked this pull request as ready for review July 26, 2022 02:32
Copy link
Collaborator

@brucestull brucestull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to submit fixes to Lab 04 on new branch.

@brucestull brucestull merged commit 04edf71 into main Jul 26, 2022
@brucestull brucestull deleted the kelin-lab04-blackjack-advice branch July 26, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants