Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the units in Ensemble / sensitivity analysis graphs labeled incorrectly? #792

Closed
serbinsh opened this issue Apr 11, 2016 · 10 comments
Closed

Comments

@serbinsh
Copy link
Member

Graph with the histogram on the left and the boxplot on the right

It is my understanding that the units are Kg C / ha / year

But they are labeled as kg C / m2 / s

@Viskari @dlebauer @ashiklom @tonygardella Am I wrong?

@serbinsh serbinsh self-assigned this Apr 11, 2016
@tonygardella
Copy link
Contributor

@serbinsh I believe it should be kg C / m2 / s. We agreed that the MsTMIP output variable names/units were what we would use and all carbon fluxes have kg C / m2 / s as units.

@serbinsh
Copy link
Member Author

Hmmm...but my resulting values are really really high. I am properly putting them into kg C / m2 / s when converting to netCDF and the values are as expected (very small) but the values on the PDFs are around like 7000+ units. Maybe if this was added over a year it would make sense but per second doesnt

@serbinsh
Copy link
Member Author

@serbinsh
Copy link
Member Author

sorry actually higher, like 72K+

@serbinsh serbinsh changed the title Units in Ensemble analysis graph are labeled incorrectly Are the units in Ensemble / sensitivity analysis graphs labeled incorrectly? Apr 11, 2016
@tonygardella
Copy link
Contributor

@serbinsh I went and looked at a bunch of runs with other models and all have the same mismatch. The time series of NPP and GPP is many orders of magnitude smaller than what the histogram shows. The magnitude of the histogram is definitely off.

@serbinsh
Copy link
Member Author

OK, thanks for the feedback @tonygardella. At least I know I am not going crazy! Maybe an extra call to unit conversions somewhere int he plotting that is causing "units gone wild" ?

@mdietze
Copy link
Member

mdietze commented Apr 11, 2016

Yes, there's a built in conversion in there. You can get rid of it if you want

@Viskari
Copy link

Viskari commented Apr 11, 2016

As Mike said there is currently a built-in conversion in pecan/utils/read.output.R which converts both NPP and GPP from kg m-2 s-1 to kg ha-1 yr-1

@serbinsh
Copy link
Member Author

kg ha-1 yr-1 is fine we just need to make sure we are putting the correct units in the ensemble and SA graphs.

@mdietze
Copy link
Member

mdietze commented Jul 26, 2016

Folks definitely questioned UNITS at flux course -- need this fixed in v1.4.8

mdietze added a commit to mdietze/pecan that referenced this issue Aug 3, 2016
 - more informative unmatched file error message.
 - attempt to reconcile units issue PecanProject#792
@mdietze mdietze closed this as completed Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants