-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are the units in Ensemble / sensitivity analysis graphs labeled incorrectly? #792
Comments
@serbinsh I believe it should be kg C / m2 / s. We agreed that the MsTMIP output variable names/units were what we would use and all carbon fluxes have kg C / m2 / s as units. |
Hmmm...but my resulting values are really really high. I am properly putting them into kg C / m2 / s when converting to netCDF and the values are as expected (very small) but the values on the PDFs are around like 7000+ units. Maybe if this was added over a year it would make sense but per second doesnt |
sorry actually higher, like 72K+ |
@serbinsh I went and looked at a bunch of runs with other models and all have the same mismatch. The time series of NPP and GPP is many orders of magnitude smaller than what the histogram shows. The magnitude of the histogram is definitely off. |
OK, thanks for the feedback @tonygardella. At least I know I am not going crazy! Maybe an extra call to unit conversions somewhere int he plotting that is causing "units gone wild" ? |
Yes, there's a built in conversion in there. You can get rid of it if you want |
As Mike said there is currently a built-in conversion in pecan/utils/read.output.R which converts both NPP and GPP from kg m-2 s-1 to kg ha-1 yr-1 |
kg ha-1 yr-1 is fine we just need to make sure we are putting the correct units in the ensemble and SA graphs. |
Folks definitely questioned UNITS at flux course -- need this fixed in v1.4.8 |
- more informative unmatched file error message. - attempt to reconcile units issue PecanProject#792
Graph with the histogram on the left and the boxplot on the right
It is my understanding that the units are Kg C / ha / year
But they are labeled as kg C / m2 / s
@Viskari @dlebauer @ashiklom @tonygardella Am I wrong?
The text was updated successfully, but these errors were encountered: