Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /admin/people/notes POST endpoint. #6936

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Fix /admin/people/notes POST endpoint. #6936

merged 1 commit into from
Dec 14, 2019

Conversation

bakert
Copy link
Member

@bakert bakert commented Dec 14, 2019

No description provided.

I had a go at understanding this and failed. This at least gets things working again :)
@TravisBuddy
Copy link

Hey @bakert,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 992530e0-1e80-11ea-8c7c-334558e6cc20

@vorpal-buildbot vorpal-buildbot merged commit 7f2182d into master Dec 14, 2019
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #6936 into master will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6936      +/-   ##
==========================================
- Coverage   41.02%   41.01%   -0.02%     
==========================================
  Files         272      272              
  Lines       13623    13624       +1     
  Branches     2044     2045       +1     
==========================================
- Hits         5589     5588       -1     
+ Misses       7794     7789       -5     
- Partials      240      247       +7
Impacted Files Coverage Δ
decksite/controllers/admin.py 43.75% <25%> (-0.76%) ⬇️
logsite/api.py 41.17% <0%> (ø) ⬆️
maintenance/elo.py 0% <0%> (ø) ⬆️
decksite/view.py 61.12% <0%> (ø) ⬆️
magic/multiverse.py 5.43% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.42% <0%> (ø) ⬆️
logsite/data/match.py 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305eca9...5b0f29d. Read the comment docs.

@vorpal-buildbot vorpal-buildbot added Pending-on-LOGS Used by the build bot Pending-on-PROD Used by the build bot Seen-on-LOGS Seen-on-PROD and removed Pending-on-LOGS Used by the build bot Pending-on-PROD Used by the build bot labels Dec 14, 2019
@vorpal-buildbot
Copy link
Contributor

Seen on LOGS, PROD (created by @bakert and merged by @vorpal-buildbot 20 seconds ago) Please check your changes!

@silasary silasary deleted the devdb branch June 9, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants