Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout #669

Merged
merged 15 commits into from
Apr 8, 2024
Merged

Update actions/checkout #669

merged 15 commits into from
Apr 8, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Apr 2, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Many actions are outdated which triggers a lot of warnings. See here for example.

Description of the Change:
Update some of the actions, those that do not introduce options requiring more in depth changes.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
Update GitHub actions in the Lightning repo [sc-60944]

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (c3fefb2) to head (c3c1851).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   98.39%   98.92%   +0.52%     
==========================================
  Files         172      206      +34     
  Lines       25166    29424    +4258     
==========================================
+ Hits        24763    29107    +4344     
+ Misses        403      317      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr added the ci:build_wheels Activate wheel building. label Apr 3, 2024
@vincentmr vincentmr added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Apr 4, 2024
@vincentmr vincentmr marked this pull request as ready for review April 5, 2024 19:15
@vincentmr vincentmr requested review from maliasadi and a team April 5, 2024 19:18
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see our actions up-to-date. Thank you, @vincentmr!

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@vincentmr vincentmr merged commit 4bca990 into master Apr 8, 2024
80 checks passed
@vincentmr vincentmr deleted the update/actions branch April 8, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants