Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove qchem deprecated functionality for fermionic observables #4556

Merged
merged 45 commits into from
Sep 7, 2023
Merged

Remove qchem deprecated functionality for fermionic observables #4556

merged 45 commits into from
Sep 7, 2023

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Aug 30, 2023 •
edited
Loading

Context:
The deprecated qchem functions and features that were using tuples to represent fermionic observables are removed. The relevant tests are updated.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@soranjh soranjh added the qchem ⚛️ Related to the QChem package label Aug 30, 2023
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@soranjh soranjh mentioned this pull request Aug 30, 2023
Merged
@lillian542
Copy link
Contributor

[sc-43900]

@lillian542
Copy link
Contributor

[sc-43904]

@lillian542
Copy link
Contributor

[sc-43905]

lillian542
lillian542 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions for the changelog, but looks good to me!

Base automatically changed from qchem_dipole_fermisentence to master September 6, 2023 21:47
Jaybsoni
Jaybsoni approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@soranjh soranjh enabled auto-merge (squash) September 7, 2023 20:43
@soranjh soranjh merged commit ea7423e into master Sep 7, 2023
38 checks passed
@soranjh soranjh deleted the qchem_remove_tuple_observable branch September 7, 2023 21:23
mudit2812 pushed a commit that referenced this pull request Sep 8, 2023
@soranjh @mudit2812
Remove qchem deprecated functionality for fermionic observables (#4556)
58fb45f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lillian542 lillian542 lillian542 approved these changes

@Jaybsoni Jaybsoni Jaybsoni approved these changes

Assignees
No one assigned
Labels
qchem ⚛️ Related to the QChem package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soranjh @lillian542 @Jaybsoni