-
Notifications
You must be signed in to change notification settings - Fork 214
sc-99549-fix-broken-demo-inter-sphinx-links-within-demo #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sc-99549-fix-broken-demo-inter-sphinx-links-within-demo #1550
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we take this opportunity to change these links to Intersphinx (:doc:`demos/slug` or :doc:`Some text <demos/slug>`), since we're planning on changing the demo URLs and removing qml
?
Your preview is ready 🎉!You can view your changes here |
This PR tweaks the `qml` build tool such that the generated objects.inv files match the naming and uris for the demos on pennylane.ai. This PR should fix #1550. Note: This has been tested locally. ~We should verify it works when building all demos as wel.~ Tested for all demos successfully [here](https://github.com/PennyLaneAI/qml/actions/runs/17866805882) --------- Co-authored-by: Alan Martin <alan.martin@xanadu.ai>
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Looks good @ashishks0522. Now we just need the html redirects and we're good. This can be merged in now. |
**Summary:** This PR reduces some of the image sizes for the `sc_qubits` demo to test out the impact on `pennylane.ai` page loading performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Changes
.html
from demo references as we no longer need that in the URL and its causing 404 with next port, update it to be intersphinx formatTicket