Fix for tests referencing files, password/username variable, and a couple KERBEROS space issues #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshall-Hallenbeck
requested review from
zblurx,
NeffIsBack and
mpgn
as code owners
…ot dir or tests dir and the path names should resolve
Marshall-Hallenbeck
force-pushed
the
marshall-tests-fix
branch
from
05e5aa8
to
2f098f2
Compare
|
Oh you were working on the tests as well. I also fixed the issue with the files. I will PR into this branch than instead of main and we figure out the rest |
mpgn
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing test files was failing if you didnt call it from the proper folder, so this should fix that
There were a couple places where KERBEROS wasnt being replaced
And finally, changed the USERNAME/PASSWORD we replace because some modules/etc have "PASSWORD" as an option and that was being erroneously replaced