-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup & Lint Code #35
Conversation
…17-010 Module, since there's a lot of byte-work
@Marshall-Hallenbeck probably found the reason why github shows some files as completely redone:
will leave it as it, now everything seems to be in EDIT: |
We need to be careful with merge conflicts in these files tho. For example pyproject.toml file is missing pyreadline now and this won't be highlighted now |
Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
@NeffIsBack tests seem good (other than missing kerberos for WinRM, but that's not related to this PR), and linting passes. I'm good with this so if you are too we should merge it and cut a v1.1.0 release along with your other stuff branched off this. |
@Marshall-Hallenbeck gonna test basic commands tomorrow just to make sure and then this is ready to merge for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉
--poetry
option for e2e tests, so all commands are prepended withpoetry run
data/
)sys.exit()
instead of justexit()
(PL)