Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return hint file loading to quoted eval to make strict vars more useful
This allows hints files to properly access $self without special magic. Note that no change to the documentation is required because the documentation has always stated that the code was 'evaled'. An audit has already been done of the existing CPAN hint files. No files use utf8 or appear to have anything beyond latin1 bytes. No BOMs were seen either. This change also reverts the behavior back to how it worked in perl 5.3. It's not clear what protection we were trying to put in place at the time. Before this change, hints have full access to the stash. Given that $self is a variable local to the subroutine, there shouldn't need to be any special protections. The only thing using do provides is protection from modifying lexically scoped package variables. This doesn't seem very valuable given that in exchange you have to say no strict 'vars' in hints.pl to get strict to be on.
- Loading branch information