-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update old Perls from jessie to stretch (and test them all in Actions) #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tianon! Looking good, just a couple of comments to maybe change:
6a04b58
to
7ab5632
Compare
I've got a script that can generate a suitable (It currently takes an optional |
98a7819
to
3aa0dea
Compare
Additionally, add buster to all of them. Finally, move all EOL versions into a completely separate `eol/` directory so that the repository is a little easier manage (and so we can limit testing of all old EOL versions to only when something inside the `eol/` directory changes).
There we go -- added |
Thanks @tianon, this looks really good! 🎉 Now that I'm certainly interested on that |
I was digging into this for #100, and figured that updating the Actions would be the easiest way to make sure they all build successfully and roughly work. 😄
In my repo, these complete in ~30 minutes total (in parallel), so it seems pretty reasonable IMO to just let it build them all, but I'm happy to back out or adjust any bit of this.
I had to make some changes to
generate.pl
(and the POD changes are the bits I'm the least sure about -- my experience with POD is super limited) so that we don't run the tests on several of these (given the caveat thatDevel::PatchPerl
doesn't actually patch for passing tests, as previously discussed) and I used essentiallyperl -de0
to run a basic smoke test for those versions instead.Update: Also, move all EOL versions into a completely separate
eol/
directory so that the repository is a little easier manage (and so we can limit testing of all old EOL versions to only when something inside theeol/
directory changes), per #101 (comment).