-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.25.0-18-g1656665 breaks STBEY/Carp-Clan-6.04.tar.gz #15323
Comments
From @andkbisect commit 1656665 Require literal '{' in patterns to be escaped diagnostics http://www.cpantesters.org/cpan/report/e647feb8-161c-11e6-9f6b-20a29ae6fa17 also affected | GFUJI/Acme-Hidek-44.0.tar.gz | http://www.cpantesters.org/cpan/report/60fdb5de-1678-11e6-9b5a-4fdc9ae6fa17 | perl -V Summary of my perl5 (revision 5 version 25 subversion 1) configuration: Characteristics of this binary (from libperl): -- |
From @andkAlso affected: ZOFFIX/App-ZofCMS-1.001006.tar.gz -- |
From @eserteDana Sub 14. Svibanj 2016, 02:09:16, andreas.koenig.7os6VVqR@franz.ak.mind.de reče:
Here's a more complete list, generated by grepping for the warning message "Unescaped left brace in regex is deprecated" in the test reports of indexed CPAN distributions residing on my disk. If there's an annotation (non rt.perl.org) in Andreas' annotate.txt, then it's added (may be related to this warning, or not). GFUJI/Acme-Hidek-44.0.tar.gz |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sat, 14 May 2016 10:37:26 GMT, slaven@rezic.de wrote:
Do we have a battle plan for handling these BBC tickets? Thank you very much. -- |
From @xsawyerxOn 12/06/2016 10:54 PM, James E Keenan via RT wrote:
We can do several things, from less likely to more likely: I think the last two are likely. I'll try to clear some time and work on Still, this is a worthy goal, so I believe at least the last one |
From @khwilliamsonOn 12/08/2016 04:09 AM, Sawyer X wrote:
My expectation was that we would revert at the last moment before One of the lessons here is that there are a significant number of module |
From @xsawyerxOn 12/08/2016 06:56 PM, Karl Williamson wrote:
Is it still your expectation?
I agree we should have provided a warning, but 5.24 had already The question is: If all of these modules were to have a patch in their
Agreed. |
From @khwilliamsonOn 12/08/2016 01:08 PM, Sawyer X wrote:
Yes
IIRC the only fatal ones were done before 5.24, and were only done for
Yes
And maybe even if it does really bite their module, some may not still |
From @jkeenanOn Sat, 14 May 2016 10:37:26 GMT, slaven@rezic.de wrote:
I'm attaching the data above in the form of a tab-separated-values file. With a 'minicpan' and one of the visitation modules, we could easily extend this table to include the bug trackers and the repositories for these distributions. -- |
From @khwilliamsonJust to be clear, there are two issues here. The deprecation warning was raised in some contexts for 2 releases before 5.26, and made fatal in 5.25. The list of modules that this breaks is in the initial messages for this ticket. In 5.25, new contexts were added that now raise a deprecation warning. These are not currently fatal, and I did not propose to make them fatal in 5.26. Slaven's and Jim's lists are mostly based on these modules. These lists are much longer than the ones that fatality is prescribed for, and no stable release has happened with the message in it. -- |
From @jkeenanOn Mon, 12 Dec 2016 20:36:55 GMT, khw wrote:
I revised my program to look only at the tickets cited by Andreas in the original post to this RT (https://rt.perl.org/Ticket/Display.html?id=128139#txn-1399922) and his follow-up post (https://rt-archive.perl.org/perl5/Ticket/Display.html?id=128139#txn-1400673). I then visited each of these distros and called 'make test' or './Build test' as needed. I went through the distros that failed due to the following exception: Unescaped left brace in regex is illegal here in regex Slaven had already opened bug tickets for most of these. ETHER has already provided pull requests for some. I created RTs and or provided patches in the RTs or github issues for the balance. If I am understanding khw correctly, distros where, at the present time (5.25 development), we are only seeing deprecation warnings due to unrecognized left braces do not need to be addressed in this RT. If so, then P5P has done all it can to address the "illegal" cases and it is my belief that this RT can be closed. Verification of the above is requested. Thank you very much. |
From @jkeenanOn Tue, 20 Dec 2016 18:34:16 GMT, jkeenan wrote:
Taking this ticket for the purpose of closing it within 7 days unless some objection is raised. Thank you very much. |
From @jkeenanOn Fri, 23 Dec 2016 13:06:20 GMT, jkeenan wrote:
No objection heard. Marking ticket Resolved. Thank you very much. -- |
@jkeenan - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#128139 (status was 'resolved')
Searchable as RT128139$
The text was updated successfully, but these errors were encountered: