Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.27.3-31-gf14cf36320 DEBUGGING breaks ETJ/Event-1.26.tar.gz #16150

Closed
p5pRT opened this issue Sep 15, 2017 · 9 comments
Closed

Bleadperl v5.27.3-31-gf14cf36320 DEBUGGING breaks ETJ/Event-1.26.tar.gz #16150

p5pRT opened this issue Sep 15, 2017 · 9 comments
Labels
BBC

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Sep 15, 2017

Migrated from rt.perl.org#132094 (status was 'resolved')

Searchable as RT132094$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 15, 2017

From @andk

bisect


commit f14cf36
Author​: Tony Cook <tony@​develop-help.com>
Date​: Mon Aug 14 11​:52​:39 2017 +1000

  (perl #131746) avoid undefined behaviour in Copy() etc

cpantesters


http​://www.cpantesters.org/cpan/report/a4656f24-92a0-11e7-a6e8-4c7815098ed7

perl -V


Summary of my perl5 (revision 5 version 27 subversion 4) configuration​:
  Commit id​: 99333cd
  Platform​:
  osname=linux
  osvers=4.9.0-2-amd64
  archname=x86_64-linux-thread-multi-ld
  uname='linux k93msid 4.9.0-2-amd64 #1 smp debian 4.9.18-1 (2017-03-30) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.3-39-g99333cdb13/ac75 -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Duseithreads -Duselongdouble -DEBUGGING=both'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=define
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2 -g'
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.3.0 20170406'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='long double'
  nvsize=16
  Off_t='off_t'
  lseeksize=8
  alignbytes=16
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  DEBUGGING
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_TRACK_MEMPOOL
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_LONG_DOUBLE
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Sep 5 2017 05​:59​:33
  %ENV​:
  PERL="/tmp/basesmoker-reloperl-aFQA/bin/perl"
  PERL5LIB=""
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="32491"
  PERL5_CPAN_IS_RUNNING="32491"
  PERL_CANARY_STABILITY_NOPROMPT="1"
  PERL_MM_USE_DEFAULT="1"
  PERL_USE_UNSAFE_INC="1"
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.3-39-g99333cdb13/ac75/lib/site_perl/5.27.4/x86_64-linux-thread-multi-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.3-39-g99333cdb13/ac75/lib/site_perl/5.27.4
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.3-39-g99333cdb13/ac75/lib/5.27.4/x86_64-linux-thread-multi-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.3-39-g99333cdb13/ac75/lib/5.27.4
  .
--
andreas

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 15, 2017

From @jkeenan

On Fri, 15 Sep 2017 04​:24​:48 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit f14cf36
Author​: Tony Cook <tony@​develop-help.com>
Date​: Mon Aug 14 11​:52​:39 2017 +1000

(perl #131746) avoid undefined behaviour in Copy() etc

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/a4656f24-92a0-11e7-a6e8-
4c7815098ed7

I could not reproduce this behavior.

I installed blead and then the most recent version of 'cpanm' on top of that perl.

#####
$ ./bin/perl -v | head -2 | tail -1
This is perl 5, version 27, subversion 4 (v5.27.4 (v5.27.3-95-g45d6710)) built for x86_64-linux
#####

I then used that 'cpanm' to install Event-1.26 successfully (apart from some C-level warnings during XS compilation). See attachment.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 15, 2017

From @jkeenan

$ ./bin/cpanm --verbose Event
cpanm (App​::cpanminus) 1.7043 on perl 5.027004 built for x86_64-linux
[snip]
Unpacking Event-1.26.tar.gz
Event-1.26/
[snip]
Entering Event-1.26
Checking configure dependencies from META.json
Checking if you have ExtUtils​::MakeMaker 6.58 ... Yes (7.30)
Running Makefile.PL
Configuring Event-1.26 ... Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Event
Writing MYMETA.yml and MYMETA.json
OK
Checking dependencies from MYMETA.json ...
Checking if you have ExtUtils​::MakeMaker 0 ... Yes (7.30)
Checking if you have Test 1 ... Yes (1.30)
Building and testing Event-1.26 ... cp lib/Event/timer.pm blib/lib/Event/timer.pm
[snip]
Running Mkbootstrap for Event ()
chmod 644 "Event.bs"
"/home/jkeenan/testing/blead/bin/perl" -MExtUtils​::Command​::MM -e 'cp_nonempty' -- Event.bs blib/arch/auto/Event/Event.bs 644
"/home/jkeenan/testing/blead/bin/perl" "/home/jkeenan/testing/blead/lib/perl5/5.27.4/ExtUtils/xsubpp" -typemap '/home/jkeenan/testing/blead/lib/perl5/5.27.4/ExtUtils/typemap' -typemap '/home/jkeenan/.cpanm/work/1505484393.28370/Event-1.26/lib/Event/typemap' Event.xs > Event.xsc
mv Event.xsc Event.c
cc -c -Ic -Ilib/Event -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"1.26\" -DXS_VERSION=\"1.26\" -fPIC "-I/home/jkeenan/testing/blead/lib/perl5/5.27.4/x86_64-linux/CORE" Event.c
In file included from Event.xs​:269​:0​:
c/var.c​: In function ‘pe_var_start’​:
c/var.c​:82​:20​: warning​: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  mg->mg_virtual = &PL_vtbl_uvar;
  ^
rm -f blib/arch/auto/Event/Event.so
cc -shared -O2 -L/usr/local/lib -fstack-protector-strong Event.o -o blib/arch/auto/Event/Event.so \
  \
 
chmod 755 blib/arch/auto/Event/Event.so
"/home/jkeenan/testing/blead/bin/perl" -MExtUtils​::Command​::MM -e 'cp_nonempty' -- Event.bs blib/arch/auto/Event/Event.bs 644
PERL_DL_NONLAZY=1 "/home/jkeenan/testing/blead/bin/perl" "-MExtUtils​::Command​::MM" "-MTest​::Harness" "-e" "undef *Test​::Harness​::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/attach_to.t ..... ok
t/bored.t ......... ok
t/callback.t ...... ok
t/data.t .......... ok
t/delete.t ........ ok
t/eval.t .......... ok
t/fifo.t .......... ok
t/generic.t ....... ok
t/group.t ......... ok
t/hook.t .......... ok
t/hup.t ........... ok
t/idle.t .......... ok
t/io.t ............ ok
t/leak.t .......... ok
t/leak2.t ......... ok
t/loop.t .......... ok
t/now.t ........... ok
t/reenter.t ....... ok
t/signal.t ........ ok
t/timeout_cb.t .... ok
t/timer.t ......... ok
t/unconfigured.t .. ok
t/var.t ........... ok
All tests successful.
Files=23, Tests=121, 10 wallclock secs ( 0.06 usr 0.02 sys + 2.44 cusr 0.43 csys = 2.95 CPU)
Result​: PASS
"/home/jkeenan/testing/blead/bin/perl" -MExtUtils​::Command​::MM -e 'cp_nonempty' -- Event.bs blib/arch/auto/Event/Event.bs 644
Files found in blib/arch​: installing files in blib/lib into architecture dependent library tree
[snip]
OK
Successfully installed Event-1.26
[snip]

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 15, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 15, 2017

From @andk

On Fri, 15 Sep 2017 07​:14​:17 -0700, "James E Keenan via RT" <perlbug-followup@​perl.org> said​:

  > I could not reproduce this behavior.

  > I installed blead and then the most recent version of 'cpanm' on top
  > of that perl.

Did you build a perl with -DDEBUGGING?

--
andreas

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 15, 2017

From @jkeenan

On Fri, 15 Sep 2017 17​:44​:09 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Fri, 15 Sep 2017 07​:14​:17 -0700, "James E Keenan via RT"
<perlbug-followup@​perl.org> said​:

I could not reproduce this behavior.

I installed blead and then the most recent version of 'cpanm' on top
of that perl.

Did you build a perl with -DDEBUGGING?

No, I did not. You are correct that the breakage occurs on -DDEBUGGING builds, as my subsequent re-build confirms.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Sep 18, 2017

From @tonycoz

On Thu, 14 Sep 2017 21​:24​:48 -0700, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit f14cf36
Author​: Tony Cook <tony@​develop-help.com>
Date​: Mon Aug 14 11​:52​:39 2017 +1000

(perl #131746) avoid undefined behaviour in Copy() etc

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/a4656f24-92a0-11e7-a6e8-
4c7815098ed7

The asserts added by this patch detect behaviour considered undefined behaviour in the C standard.

In this case, calling memset() with a NULL pointer (hidden in a Zero() macro) at line 272 in c/unix.c

Tony

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 19, 2018

From @iabyn

On Sun, Sep 17, 2017 at 09​:04​:47PM -0700, Tony Cook via RT wrote​:

On Thu, 14 Sep 2017 21​:24​:48 -0700, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit f14cf36
Author​: Tony Cook <tony@​develop-help.com>
Date​: Mon Aug 14 11​:52​:39 2017 +1000

(perl #131746) avoid undefined behaviour in Copy() etc

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/a4656f24-92a0-11e7-a6e8-
4c7815098ed7

The asserts added by this patch detect behaviour considered undefined behaviour in the C standard.

In this case, calling memset() with a NULL pointer (hidden in a Zero() macro) at line 272 in c/unix.c

There is a cpan ticket for this​:

  https://rt.cpan.org/Public/Bug/Display.html?id=123115

Closing the perl ticket.

--
Justice is when you get what you deserve.
Law is when you get what you pay for.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

@iabyn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 20, 2018
@p5pRT p5pRT added BBC Severity Low labels Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC
Projects
None yet
Development

No branches or pull requests

1 participant