Dirty compile Compress-Raw-Bzip2/decompress.c #17528
Description
Description
I'm building Perl from the 5.30.1 release tarball. A couple files have very dirty compiles. I don't normally file bug reports for trivial noise, but these files produce a lot of noise and may cover up important warnings.
./cpan/Compress-Raw-Bzip2/bzip2-src/decompress.c
./cpan/Compress-Raw-Bzip2/decompress.c
It looks like a macro is causing it:
#define GET_BITS(lll,vvv,nnn) \
case lll: s->state = lll; \
while (True) { \
... \
}
If the fall-through is intended, you typically mark it as such with a comment. Modern compilers use the comment to suppress the warning. Maybe something like:
#define GET_BITS(lll,vvv,nnn) \
case lll: s->state = lll; /* fall-through */ \
while (True) { \
... \
}
Or:
#define GET_BITS(lll,vvv,nnn) \
case lll: s->state = lll; \
while (True) { \
... \
} \
/* fall-through */
Steps to Reproduce
Build the release tarball with a modern compiler. Use V=1 to see output of the compile.
Expected behavior
A cleaner compile that can pass an audit.
Perl configuration
$ PERL5LIB=lib:$PERL5LIB ./perl -V
Summary of my perl5 (revision 5 version 30 subversion 1) configuration:
Platform:
osname=linux
osvers=4.19.80-0-vanilla
archname=x86_64-linux
uname='linux alpine3-x64 4.19.80-0-vanilla #1-alpine smp fri oct 18 11:27:53 utc 2019 x86_64 linux '
config_args='-des -Dprefix=/usr/local -Dlibdir=/usr/local/lib -Dpkgconfig=/usr/local/lib/pkgconfig -Dcc=gcc -Acppflags=-I/usr/local/include -DNDEBUG -Accflags=-g2 -O2 -march=native -fPIC -pthread -Aldflags=-L/usr/local/lib -Wl,-R,'$$ORIGIN/../lib' -Wl,-R,/usr/local/lib -Wl,--enable-new-dtags -Dextras=Text::Template Test::More'
hint=recommended
useposix=true
d_sigaction=define
useithreads=undef
usemultiplicity=undef
use64bitint=define
use64bitall=define
uselongdouble=undef
usemymalloc=n
default_inc_excludes_dot=define
bincompat5005=undef
Compiler:
cc='gcc'
ccflags ='-g2 -O2 -march=native -fPIC -pthread -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
optimize='-O2'
cppflags='-I/usr/local/include -DNDEBUG -g2 -O2 -march=native -fPIC -pthread -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
ccversion=''
gccversion='8.3.0'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='double'
nvsize=8
Off_t='off_t'
lseeksize=8
alignbytes=8
prototype=define
Linker and Libraries:
ld='gcc'
ldflags =' -L/usr/local/lib -Wl,-R,11928ORIGIN/../lib -Wl,-R,/usr/local/lib -Wl,--enable-new-dtags -fstack-protector-strong'
libpth=/usr/local/lib /usr/lib /lib/../lib /usr/lib/../lib /lib
libs=-lpthread -ldb -ldl -lm -lcrypt -lutil -lc
perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
libc=/usr/lib/libc.a
so=so
useshrplib=false
libperl=libperl.a
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_dlopen.xs
dlext=so
d_dlsymun=undef
ccdlflags='-Wl,-E'
cccdlflags='-fPIC'
lddlflags='-shared -O2 -L/usr/local/lib -Wl,-R,11928ORIGIN/../lib -Wl,-R,/usr/local/lib -fstack-protector-strong'
Characteristics of this binary (from libperl):
Compile-time options:
HAS_TIMES
PERLIO_LAYERS
PERL_COPY_ON_WRITE
PERL_DONT_CREATE_GVSV
PERL_MALLOC_WRAP
PERL_OP_PARENT
PERL_PRESERVE_IVUV
USE_64_BIT_ALL
USE_64_BIT_INT
USE_LARGE_FILES
USE_LOCALE
USE_LOCALE_COLLATE
USE_LOCALE_CTYPE
USE_LOCALE_NUMERIC
USE_LOCALE_TIME
USE_PERLIO
USE_PERL_ATOF
Built under linux
Compiled at Feb 4 2020 10:32:16
%ENV:
PERL5LIB="lib:"
@INC:
lib
/usr/local/lib/perl5/site_perl/5.30.1/x86_64-linux
/usr/local/lib/perl5/site_perl/5.30.1
/usr/local/lib/perl5/5.30.1/x86_64-linux
/usr/local/lib/perl5/5.30.1
Here is the output.
gcc -c -I. -g2 -O2 -march=native -fPIC -pthread -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror=declaration-after-statement -Werror=pointer-arith -Wextra -Wc++-compat -Wwrite-strings -O2 -DVERSION=\"2.084\" -DXS_VERSION=\"2.084\" -fPIC "-I../.." -Wall -Wno-comment -DBZ_NO_STDIO decompress.c
decompress.c: In function 'BZ2_decompress':
decompress.c:198:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != BZ_HDR_B) RETURN(BZ_DATA_ERROR_MAGIC);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:200:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_MAGIC_2, uc);
^~~~~~~~~
decompress.c:201:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != BZ_HDR_Z) RETURN(BZ_DATA_ERROR_MAGIC);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:203:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_MAGIC_3, uc)
^~~~~~~~~
decompress.c:204:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != BZ_HDR_h) RETURN(BZ_DATA_ERROR_MAGIC);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:206:7: note: in expansion of macro 'GET_BITS'
GET_BITS(BZ_X_MAGIC_4, s->blockSize100k, 8)
^~~~~~~~
decompress.c:211:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (s->smallDecompress) {
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:222:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BLKHDR_1, uc);
^~~~~~~~~
decompress.c:225:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x31) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:226:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BLKHDR_2, uc);
^~~~~~~~~
decompress.c:227:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x41) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:228:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BLKHDR_3, uc);
^~~~~~~~~
decompress.c:229:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x59) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:230:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BLKHDR_4, uc);
^~~~~~~~~
decompress.c:231:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x26) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:232:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BLKHDR_5, uc);
^~~~~~~~~
decompress.c:233:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x53) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:234:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BLKHDR_6, uc);
^~~~~~~~~
decompress.c:241:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedBlockCRC = 0;
~~~~~~~~~~~~~~~~~~^~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:242:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BCRC_1, uc);
^~~~~~~~~
decompress.c:243:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedBlockCRC = (s->storedBlockCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:244:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BCRC_2, uc);
^~~~~~~~~
decompress.c:245:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedBlockCRC = (s->storedBlockCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:246:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BCRC_3, uc);
^~~~~~~~~
decompress.c:247:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedBlockCRC = (s->storedBlockCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:248:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_BCRC_4, uc);
^~~~~~~~~
decompress.c:249:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedBlockCRC = (s->storedBlockCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:251:7: note: in expansion of macro 'GET_BITS'
GET_BITS(BZ_X_RANDBIT, s->blockRandomised, 1);
^~~~~~~~
decompress.c:253:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->origPtr = 0;
~~~~~~~~~~~^~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:254:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ORIGPTR_1, uc);
^~~~~~~~~
decompress.c:255:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->origPtr = (s->origPtr << 8) | ((Int32)uc);
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:256:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ORIGPTR_2, uc);
^~~~~~~~~
decompress.c:257:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->origPtr = (s->origPtr << 8) | ((Int32)uc);
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:258:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ORIGPTR_3, uc);
^~~~~~~~~
decompress.c:284:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
alphaSize = s->nInUse+2;
~~~~~~~~~~^~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:287:7: note: in expansion of macro 'GET_BITS'
GET_BITS(BZ_X_SELECTOR_1, nGroups, 3);
^~~~~~~~
decompress.c:288:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (nGroups < 2 || nGroups > 6) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:289:7: note: in expansion of macro 'GET_BITS'
GET_BITS(BZ_X_SELECTOR_2, nSelectors, 15);
^~~~~~~~
decompress.c:292:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
j = 0;
~~^~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:71:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,1)
^~~~~~~~
decompress.c:294:13: note: in expansion of macro 'GET_BIT'
GET_BIT(BZ_X_SELECTOR_3, uc);
^~~~~~~
decompress.c:321:19: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (curr < 1 || curr > 20) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:71:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,1)
^~~~~~~~
decompress.c:322:16: note: in expansion of macro 'GET_BIT'
GET_BIT(BZ_X_CODING_2, uc);
^~~~~~~
decompress.c:323:19: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc == 0) break;
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:71:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,1)
^~~~~~~~
decompress.c:324:16: note: in expansion of macro 'GET_BIT'
GET_BIT(BZ_X_CODING_3, uc);
^~~~~~~
decompress.c:88:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
zn = gMinlen; \
~~~^~~~~~~~~
decompress.c:373:7: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_1, BZ_X_MTF_2, nextSym);
^~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:89:4: note: in expansion of macro 'GET_BITS'
GET_BITS(label1, zvec, zn); \
^~~~~~~~
decompress.c:373:7: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_1, BZ_X_MTF_2, nextSym);
^~~~~~~~~~~
decompress.c:94:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
zn++; \
~~^~
decompress.c:373:7: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_1, BZ_X_MTF_2, nextSym);
^~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:71:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,1)
^~~~~~~~
decompress.c:95:7: note: in expansion of macro 'GET_BIT'
GET_BIT(label2, zj); \
^~~~~~~
decompress.c:373:7: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_1, BZ_X_MTF_2, nextSym);
^~~~~~~~~~~
decompress.c:88:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
zn = gMinlen; \
~~~^~~~~~~~~
decompress.c:483:13: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_5, BZ_X_MTF_6, nextSym);
^~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:89:4: note: in expansion of macro 'GET_BITS'
GET_BITS(label1, zvec, zn); \
^~~~~~~~
decompress.c:483:13: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_5, BZ_X_MTF_6, nextSym);
^~~~~~~~~~~
decompress.c:94:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
zn++; \
~~^~
decompress.c:483:13: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_5, BZ_X_MTF_6, nextSym);
^~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:71:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,1)
^~~~~~~~
decompress.c:95:7: note: in expansion of macro 'GET_BIT'
GET_BIT(label2, zj); \
^~~~~~~
decompress.c:483:13: note: in expansion of macro 'GET_MTF_VAL'
GET_MTF_VAL(BZ_X_MTF_5, BZ_X_MTF_6, nextSym);
^~~~~~~~~~~
decompress.c:585:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x72) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:586:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ENDHDR_3, uc);
^~~~~~~~~
decompress.c:587:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x45) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:588:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ENDHDR_4, uc);
^~~~~~~~~
decompress.c:589:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x38) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:590:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ENDHDR_5, uc);
^~~~~~~~~
decompress.c:591:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (uc != 0x50) RETURN(BZ_DATA_ERROR);
^
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:592:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_ENDHDR_6, uc);
^~~~~~~~~
decompress.c:595:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedCombinedCRC = 0;
~~~~~~~~~~~~~~~~~~~~~^~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:596:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_CCRC_1, uc);
^~~~~~~~~
decompress.c:597:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedCombinedCRC = (s->storedCombinedCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:598:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_CCRC_2, uc);
^~~~~~~~~
decompress.c:599:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedCombinedCRC = (s->storedCombinedCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:600:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_CCRC_3, uc);
^~~~~~~~~
decompress.c:601:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
s->storedCombinedCRC = (s->storedCombinedCRC << 8) | ((UInt32)uc);
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
decompress.c:44:4: note: here
case lll: s->state = lll; \
^~~~
decompress.c:68:4: note: in expansion of macro 'GET_BITS'
GET_BITS(lll,uuu,8)
^~~~~~~~
decompress.c:602:7: note: in expansion of macro 'GET_UCHAR'
GET_UCHAR(BZ_X_CCRC_4, uc);
^~~~~~~~~
mv Dumper.xsc Dumper.c