Compress-Raw-Zlib customizations in core distribution: removable?

[jkeenan]

Today while preparing to run Porting/sync-with-cpan to bring Compress-Raw-Zlib's new release (version 2.205) into blead, I was notified that there are customizations in blead which presumably differ from corresponding files upstream. From Porting/Maintainers.pl:

    'Compress::Raw::Zlib' => {
        'DISTRIBUTION' => 'PMQS/Compress-Raw-Zlib-2.204.tar.gz',
        'FILES'    => q[cpan/Compress-Raw-Zlib],
        'EXCLUDED' => [
            qr{^examples/},
            qr{^t/Test/},
            qr{^t/meta},
            qw( t/000prereq.t
                t/99pod.t
                ),
        ],
        'CUSTOMIZED' => [
            # https://github.com/pmqs/Compress-Raw-Zlib/issues/23
            'lib/Compress/Raw/Zlib.pm',
            'Zlib.xs'
        ],
    },

@pqms has released a new version (2.205) of this distribution to CPAN. I cloned his repo and examined the current differences for Zlib.xs and lib/Compress/Raw/Zlib.pm.

For Zlib.xs:

$ diff Zlib.xs ~/gitwork/perl/cpan/Compress-Raw-Zlib/Zlib.xs 
954,964d953
< const char*
< ZLIBNG_VER_STATUS()
<     CODE:
< #ifdef ZLIBNG_VER_STATUS
<         RETVAL = STRINGIFY(ZLIBNG_VER_STATUS);
< #else
<         RETVAL = "0";
< #endif
<     OUTPUT:
<         RETVAL
< 

Should we remove the customization and presume upstream is now correct?

For lib/Compress/Raw/Zlib.pm:

$ diff lib/Compress/Raw/Zlib.pm ~/gitwork/perl/cpan/Compress-Raw-Zlib/lib/Compress/Raw/Zlib.pm
13c13
< $VERSION = '2.205';
---
> $VERSION = '2.204_001';
1285c1285
<         while length $input;
---
>         while ($status == Z_OK && length $input);
1456c1456
<         while length $input;
---
>         while ($status == Z_OK && length $input);

Which is better (upstream on left; current core on right)?

Note: The customizations in blead appear to date back to 2009: commits 319fab5 and dc82791, originally submitted by @pqms. The upstream GH issue commented on in Maintainers.pl has been closed.

Thank you very much.
Jim Keenan

[jkeenan]

Handled by commit 6aa3481; closing. Thanks.