reset(): call set magic when clearing SVs #21030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset() with an argument would clear the specified SVs when requested but didn't call set magic, this would result in the effect on magic variables not applying, such as the $| and $^W used in the ticket. This isn't a problem for AVs and HVs as their corresponding clear functions do call the appropriate clear magic. Fixes Perl#20763
tonycoz
added
the
defer-next-dev
|
This may |
tonycoz
removed
the
defer-next-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset()with an argument would clear the specified SVs when requested but didn't call set magic, this would result in the effect on magic variables not applying, such as the$|and$^Wused in the ticket.This isn't a problem for AVs and HVs as their corresponding clear functions do call the appropriate clear magic.
Fixes #20763