Skip to content

make sure "use VERSION;" sets the flag needed for "used only once" #21284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged

make sure "use VERSION;" sets the flag needed for "used only once" #21284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion op.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7907,8 +7907,10 @@ Perl_utilize(pTHX_ int aver, I32 floor, OP *version, OP *idop, OP *arg)
if (!(PL_hints & HINT_EXPLICIT_STRICT_VARS))
PL_hints |= HINT_STRICT_VARS;

if (shortver >= SHORTVER(5, 35))
if (shortver >= SHORTVER(5, 35)) {
free_and_set_cop_warnings(&PL_compiling, pWARN_ALL);
PL_dowarn |= G_WARN_ONCE;
}
}
/* otherwise they are off */
else {
Expand Down
7 changes: 7 additions & 0 deletions t/lib/warnings/gv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,3 +292,10 @@ if ($ㄒ) {
EXPECT
Name "팣칵ぇ::ʎ" used only once: possible typo at - line 11.
Use of uninitialized value $팣칵ぇ::ʎ in print at - line 11.
########
# https://github.com/Perl/perl5/issues/21271
use v5.36;
no strict;
my $x = $i;
EXPECT
Name "main::i" used only once: possible typo at - line 4.