Skip to content

Fix three issues building with the sun/oracle workshop compiler #21610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Fix three issues building with the sun/oracle workshop compiler #21610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4ed4ee
sun/oracle workshop cc: use -O1 (same as -xO1) to around probable bug
tonycoz Nov 2, 2023
2d3e973
sun/oracle workshop c99: allow for trailing zero size arrays
tonycoz Nov 2, 2023
b17b9cc
ext/POSIX/t/math.t: don't assume the sign of NaN
tonycoz Nov 2, 2023
9b6ba20
POSIX: the fallback copysign() doesn't handle NaNs
tonycoz Nov 5, 2023
c0ae046
POSIX: MSVC really does have copysign
tonycoz Nov 5, 2023
2a6624f
POSIX: MSVC really does have signbit()
tonycoz Nov 6, 2023
5414431
POSIX: MSVC defines all of these
tonycoz Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/POSIX/t/math.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ SKIP: {
if ($^O =~ /VMS/) {
skip "running in $^O, C99 math support uneven";
}
if ($Config{cc} =~ /\b(?:cl|icl)/) {
skip "Microsoft compiler - C99 math support uneven";
}

near(M_SQRT2, 1.4142135623731, "M_SQRT2", 1e-9);
near(M_E, 2.71828182845905, "M_E", 1e-9);
Expand Down Expand Up @@ -293,7 +290,10 @@ SKIP: {
like(NAN, qr/^NaN/, "NAN is Perl's NaN");
cmp_ok(NAN, '!=', NAN, "NAN != NAN");
ok(!(NAN == NAN), "NAN == NAN");
ok(!signbit(NAN), "signbit(NAN)");
# we have a fallback copysign(), but it doesn't work for NaN
skip('no copysign', 2) unless $Config{d_copysign};
ok(!signbit(copysign(NAN, 1.0)), "signbit(copysign(NAN, 1.0)))");
ok(signbit(copysign(NAN, -1.0)), "signbit(copysign(NAN, -1.0)))");
}

done_testing();
13 changes: 12 additions & 1 deletion hints/linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ case "`${cc:-cc} -V 2>&1`" in
# 'Sun' and the 'C': Examples:
# cc: Sun C 5.9 Linux_i386 Patch 124871-01 2007/07/31
# cc: Sun Ceres C 5.10 Linux_i386 2008/07/10
test "$optimize" || optimize='-xO2'
# cc: Studio 12.6 Sun C 5.15 Linux_i386 2017/05/30
# GH #21535 - apparent optimization bug in workshop cc
test "$optimize" || optimize='-O1'
cccdlflags='-KPIC'
lddlflags='-G -Bdynamic'
# Sun C doesn't support gcc attributes, but, in many cases, doesn't
Expand All @@ -123,6 +125,15 @@ case "`${cc:-cc} -V 2>&1`" in
d_attribute_pure='undef'
d_attribute_unused='undef'
d_attribute_warn_unused_result='undef'
case "$cc" in
*c99) # Without -Xa c99 errors on some Linux system headers
# in particular zero sized arrays at the end of structs
case "$ccflags" in
*-Xa*) ;;
*) ccflags="$ccflags -Xa" ;;
esac
;;
esac
;;
esac

Expand Down
10 changes: 5 additions & 5 deletions hints/solaris_2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,18 +365,18 @@ EOM
d_attribute_unused='undef'
d_attribute_warn_unused_result='undef'
case "$cc" in
*c99) # c99 rejects bare '-O'.
case "$optimize" in
''|-O) optimize=-O3 ;;
esac
# Without -Xa c99 doesn't see
*c99) # Without -Xa c99 doesn't see
# many OS interfaces.
case "$ccflags" in
*-Xa*) ;;
*) ccflags="$ccflags -Xa" ;;
esac
;;
esac
# GH #21535 - apparent optimization bug in workshop cc
case "$optimize" in
''|-O) optimize=-O1 ;;
esac
;;
esac
fi
Expand Down
16 changes: 8 additions & 8 deletions win32/config.vc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ d__fwalk='undef'
d_accept4='undef'
d_access='define'
d_accessx='undef'
d_acosh='undef'
d_acosh='define'
d_aintl='undef'
d_alarm='define'
d_archlib='define'
d_asctime64='undef'
d_asctime_r='undef'
d_asinh='undef'
d_atanh='undef'
d_asinh='define'
d_atanh='define'
d_atolf='undef'
d_atoll='undef'
d_attribute_always_inline='undef'
Expand Down Expand Up @@ -133,8 +133,8 @@ d_class='undef'
d_clearenv='undef'
d_closedir='define'
d_cmsghdr_s='undef'
d_copysign='undef'
d_copysignl='undef'
d_copysign='define'
d_copysignl='define'
d_cplusplus='undef'
d_crypt='define'
d_crypt_r='undef'
Expand Down Expand Up @@ -186,7 +186,7 @@ d_eofnblk='define'
d_erf='undef'
d_erfc='undef'
d_eunice='undef'
d_exp2='undef'
d_exp2='define'
d_expm1='undef'
d_faststdio='define'
d_fchdir='undef'
Expand Down Expand Up @@ -529,7 +529,7 @@ d_siginfo_si_pid='undef'
d_siginfo_si_status='undef'
d_siginfo_si_uid='undef'
d_siginfo_si_value='undef'
d_signbit='undef'
d_signbit='define'
d_sigprocmask='undef'
d_sigsetjmp='undef'
d_sin6_scope_id='define'
Expand Down Expand Up @@ -593,7 +593,7 @@ d_tcgetpgrp='undef'
d_tcsetpgrp='undef'
d_telldir='define'
d_telldirproto='define'
d_tgamma='undef'
d_tgamma='define'
d_thread_local='undef'
d_thread_safe_nl_langinfo_l='undef'
d_time='define'
Expand Down