[Win32] define HAS_TRUNC and $Config{d_trunc)for MSVC builds #21670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR might well be approved simply on the basis that supported MSVC compilers now provide the
trunc
function, but there's a little bit more to it.Following the merging of PR #21610, ext/POSIX/t/math.t now fails 5 tests - though this happens only on 32-bit perl-5.39.5 (MSWin32-x86-multi-thread), built using MSVC.
Here are the failures:
Prior to the merging of #21610, these failing tests were skipped on this platform.
There's no problem with MSWin32-x86-multi-thread-64int - the failures occur only when ivsize is 4.
And there's no problem with the comparable mingw-w64 builds.
By defining
HAS_TRUNC
(in win32/config_H.vc) andd_trunc
(in win32/config.vc), these tests all pass on the problem platform.Importantly, with these changes in place, the MSVC builds of the MSWin32-x86-multi-thread-64int and MSWin32-x64-multi-thread configurations still continue to pass all tests.
I have tested this using configurations of current blead built with VS2022.