Skip to content

Conversation

tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Jan 10, 2024

I hadn't expected code to be taking pointers or references to AX, which turned out to be wrong, so make them Stack_off_t.

This allows XS::Framework or similar code to build with a default build of perl, but it will still fail to build if perl is built with -DPERL_STACK_OFFSET_SSIZET, which can only be fixed by updating XS::Framework to use Stack_off_t itself.

Fixes #21782

I hadn't expected code to be taking pointers or references to AX,
which turned out to be wrong, so make them Stack_off_t.

This allows XS::Framework or similar code to build with a default
build of perl, but it will still fail to build if perl is built
with -DPERL_STACK_OFFSET_SSIZET, which can only be fixed by updating
XS::Framework to use Stack_off_t itself.

Fixes Perl#21782
Copy link
Contributor

@jkeenan jkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build perl from this branch and install it, then use cpan to install XS::Framework. I did not review the code changes per se, nor did I run the core test suite.

@tonycoz tonycoz merged commit 11c545f into Perl:blead Jan 10, 2024
@dur-randir
Copy link
Member

I've published a fresh XS::Framework version with appropriate #ifdefs, so now it's ready for -DPERL_STACK_OFFSET_SSIZET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BBC: 5.39.4 breaks SYBER/XS-Framework-1.5.5.tar.gz

5 participants