Skip to content

Add describe (patchlevel) to .git_patch and read it from make_patchnum.pl #22980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thibaultduponchelle
Copy link
Member

Description

This change request is related to #17199

These are obviously rather different. One notable difference is the git_describe value. It isn't possible to get a describe-style identifier using this mechanism.

It seems that since then, we can now generate describe-style identifier (also known as "patchlevel" in Test::Smoke) using export-subst

@haarg @demerphq @atoomic @toddr

This change is also preliminary work to make Test::Smoke rely more on .git_patch


  • This set of changes does not require a perldelta entry.

Copy link
Collaborator

@demerphq demerphq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thibaultduponchelle thibaultduponchelle merged commit d03bc0c into Perl:blead Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants