fix header parser single quote bug #22996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
Feb 13, 2025
demerphq
force-pushed
the
yves/fix_HeaderParser_single_quote_bug
branch
2 times, most recently
from
107cc35 to
963ec8c
Compare
We were not handling things like '\\' '\x01' nor 'ABCD' (multichar constants), nor were we handling spaces in expressions like "defined (foo)", also we weren't testing that we were warning free. This patch also includes support for auto-updating the two larger tests in t/porting/header_parser.t, now if you set the env var PERL_DEV_UPDATE_TESTFILE to a true value and run the script it will autoupdate the script with the latest output that is generated.
demerphq
force-pushed
the
yves/fix_HeaderParser_single_quote_bug
branch
from
963ec8c to
0d349a6
Compare
There are constructor options to control this, but we default to on.
demerphq
force-pushed
the
yves/fix_HeaderParser_single_quote_bug
branch
from
92eac9c to
6b26526
Compare
mauke
approved these changes
Feb 14, 2025
khwilliamson
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderParser.pm - parse single quoted backslash properly
@khwilliamson gave me a test script which was breaking because we did not handle single quoted escapes like '\' and '\n' and the like. This fixes the tokenizer pattern to handle these without dieing, although we do not validate that the escape sequence itself is legal, we no longer choke on having backslash something in the single quote.
This patch sequence also includes a commit which teaches t/porting/header_parser.t how to update its own Data::Dumper based test. Updating this test manually was annoying, so I made the script do it for us when needed.