MY_CXT: don't SEGV on a 1-byte struct. #23309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MY_CXT mechanism allows XS code to declare a 'static' struct
which is actually per-interpreter. Behind the scenes, the memory for
this struct is allocated as the PVX buf of an SV. If the size of the
struct is 1 (e.g. '{ char foo }' ) then newSV(size-1) gets called
as newSV(0), which skips allocating a PVX buffer. SEGVs ensue.
|
LGTM. |
mauke
approved these changes
May 20, 2025
|
Thanks Dave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MY_CXT mechanism allows XS code to declare a 'static' struct which is actually per-interpreter. Behind the scenes, the memory for this struct is allocated as the PVX buf of an SV. If the size of the struct is 1 (e.g. '{ char foo }' ) then newSV(size-1) gets called as newSV(0), which skips allocating a PVX buffer. SEGVs ensue.