Skip to content

Avoid some UTF8SKIPs #23695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Avoid some UTF8SKIPs #23695

wants to merge 5 commits into from

Conversation

khwilliamson
Copy link
Contributor

@khwilliamson khwilliamson commented Sep 8, 2025 •
edited
Loading

This value is returnable from the called functions. And those functions have actually verified every byte that comprises the code point, so it is safer and better practice to use this value, instead of UTF8SKIP, which looks just at the first byte.

  • This set of changes does not require a perldelta entry.

@khwilliamson khwilliamson changed the title regcomp.c: Avoid a UTF8SKIP Avoid some UTF8SKIPs Sep 8, 2025
tonycoz
tonycoz reviewed Sep 10, 2025
View reviewed changes
@khwilliamson
regcomp.c: Avoid a UTF8SKIP
8bb9817 
This value is returnable from the called function.  Use it instead of
re-deriving it
@khwilliamson
locale.c: Avoid a UTF8SKIP
d0955c8 
This value is returnable from the called function.  Use it instead of
re-deriving it
@khwilliamson
regexec.c: regrepeat: Avoid UTF8SKIPs
1529196 
This value is returnable from the called functions.  Use it instead of
re-deriving it
@khwilliamson
toke.c: Remove unnecessary code
8b8dbd7 
If a character matches isSPACE, it must be an ASCII character, and hence
its length is 1.  No need check for and call UTF8SKIP on it.
@khwilliamson
toke.c: Avoid some UTF8SKIPs
ea90d42 
This value is returnable from the called functions.  Use it instead of
re-deriving it
@khwilliamson khwilliamson added the Use merge commit Don't merge this p.r. from github It contains multiple related commits. Instructions in perlgit label Sep 11, 2025
@khwilliamson
Copy link
Contributor Author

Merged via 4312203 and 8cfa17a

@khwilliamson khwilliamson deleted the rm_utf8skips branch September 15, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonycoz tonycoz tonycoz approved these changes

Assignees

No one assigned

Labels

Use merge commit Don't merge this p.r. from github It contains multiple related commits. Instructions in perlgit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khwilliamson @tonycoz