Skip to content

Exercise documentation claim about 'goto EXPR' #23814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Exercise documentation claim about 'goto EXPR' #23814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 38 additions & 9 deletions t/op/goto.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ BEGIN {
use warnings;
use strict;
use Config;
plan tests => 95;
plan tests => 97;

our $TODO;

Expand Down Expand Up @@ -232,7 +232,7 @@ EOT
close $f;

$r = runperl(prog => 'BEGIN { unshift @INC, q[.] } use Op_goto01; print qq[DONE\n]');
is($r, "OK\nDONE\n", "goto within use-d file");
is($r, "OK\nDONE\n", "goto within use-d file");
unlink_all "Op_goto01.pm";

# test for [perl #24108]
Expand Down Expand Up @@ -300,8 +300,8 @@ moretests:
}

$z = 0;
L2:
{
L2:
{
$z += 10;
is($z, 10, 'prefer this scope (block body) to outer scope (block entry)');
goto L2 if $z == 10;
Expand All @@ -311,7 +311,7 @@ moretests:
}


{
{
$z = 0;
while (1) {
L3: # not inner scope
Expand All @@ -326,7 +326,7 @@ moretests:
}

L4: # not outer scope
{
{
$z = 0;
while (1) {
L4: # not inner scope
Expand All @@ -342,10 +342,10 @@ moretests:

{
my $loop = 0;
for my $x (0..1) {
for my $x (0..1) {
L2: # without this, fails 1 (middle) out of 3 iterations
$z = 0;
L2:
L2:
$z += 10;
is($z, 10,
"same label, multiple times in same scope (choose 1st) $loop");
Expand Down Expand Up @@ -586,7 +586,7 @@ TODO: {
FASTCGI_NEXT_REQUEST:
last;
}

sub that_cgi_script {
local $SIG{__DIE__} = sub { print "die handler\n"; exit; print "exit failed?\n"; };
print "before\n";
Expand Down Expand Up @@ -683,3 +683,32 @@ eval {
};
is $@,'', 'goto the first parameter of a binary expression [perl #132854]';

# [GH-23806]
{
my $orig = "(A)";
my $exp = '(A)(B)(tobermory)';

my ($refoo, $sefoo) = ($orig x 2);
$refoo = $sefoo = "(A)";

if($refoo eq $refoo) {
goto ORINOCO;
}
$refoo .= "(X)";
ORINOCO:
sub pudley { return "tobermory"; }
$refoo .= "(B)";
$refoo .= "(".pudley().")";
is($refoo, $exp, "GH-23806: goto LABEL worked as expected");

if($sefoo eq $sefoo) {
goto ("AMA")."ZON";
}
$sefoo .= "(X)";
AMAZON:
sub canterbury { return "tobermory"; }
$sefoo .= "(B)";
$sefoo .= "(".canterbury().")";
is($sefoo, $refoo,
"GH-23806: goto EXPR exempt from 'looks like a function' rule; worked as expected");
}
Loading