Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated keyword in plugins: request #1654

Closed
xsawyerx opened this issue Mar 12, 2022 · 1 comment
Closed

Deprecated keyword in plugins: request #1654

xsawyerx opened this issue Mar 12, 2022 · 1 comment
Labels
Deprecated Features, code, etc. that are officially deprecated
Milestone
March 2023 Deprec...

Comments

@xsawyerx
Copy link
Member

Why?

Just like the plugin_setting keyword in plugins, this is also a keyword from the old plugins interface. There is no need for this keyword since the new plugins interface is object-oriented and has the available methods.

Benefits to Dancer2 codebase

A cleaner, leaner code-base.

Benefit to Dancer2 Community

A more consistent, less confusing interface.

Alternatives

When writing a plugin, use the $self->app->request() method instead.
@xsawyerx xsawyerx added the Deprecated Features, code, etc. that are officially deprecated label Mar 12, 2022
@xsawyerx xsawyerx added this to the March 2023 Deprecations milestone Mar 12, 2022
@cromedome
Copy link
Contributor

Deprecated in #1696. Closing.

cromedome added a commit that referenced this issue Oct 9, 2023
@cromedome
v1.0.0
ab2a50a 
    [ BUG FIXES ]
    * GH #1663: Allow overriding of prefix in add_route (GeekRuthie)
    * GH #1675: Stringify VERSION_FROM correctly in Makefile.PL (Jason
      A. Crome)
    * GH #1677: Don't deserialize multipart form data on post (Emil
      Perhinschi)
    * GH #1694: Update JS assets in Dancer2 app skel (Jason A. Crome)

    [ ENHANCEMENTS ]
    * PR #1682: Bump minimum version of Perl to 5.14 (Jason A. Crome)

    [ DOCUMENTATION ]
    * GH #1580: Document the purpose of the .dancer file (Jason A. Crome)
    * GH #1669: Show correct usage of Dancer2::Core::Error (GeekRuthie)
    * GH #1674: Fix POD for input_handle() (mauke)
    * GH #1414: Add documentation resources to the doc map (Jason A.
      Crome, Yanick Champoux)
    * PR #1684: Remove shumphrey from core developers (Steven Humphrey)
    * GH #1685: Document the versioning scheme and Dancer2 release
      process (Jason A. Crome)
    * PR #1688: Fixed various bugs/issues in Dancer2 Pod (Jason A. Crome)
    * PR #1691: Update the contribution guidelines (Jason A. Crome)
    * PR #1692: Change README extension .mkdn -> .md (Jason A. Crome)

    [ DEPRECATED ]
    * GH #1645: Deprecated Dancer2::Test (Jason A. Crome)
    * GH #1646: Deprecated keyword: push_header (Jason A. Crome)
    * GH #1647: Deprecated keyword: header (Jason A. Crome)
    * GH #1648: Deprecated keyword: headers (Jason A. Crome)
    * GH #1649: Deprecated keyword: context (Jason A. Crome)
    * GH #1650: Deprecated: splat/capture named placeholders (Jason A.
      Crome)
    * GH #1651: Deprecated core Request instance method:
      request->dispatch_path (Jason A. Crome)
    * GH #1652: Deprecated keyword in plugins: plugin_setting (Jason A.
      Crome)
    * GH #1653: Deprecated keyword in plugins: dancer_app (Jason A. Crome)
    * GH #1654: Deprecated keyword in plugins: request (Jason A. Crome)
    * GH #1655: Deprecated keyword in plugins: var (Jason A. Crome)
    * GH #1656: Deprecated keyword in plugins: hook (Jason A. Crome)

    [ MISC ]
    * GH #1659: Rename `master` branch to be `main` (Yanick Champoux)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecated Features, code, etc. that are officially deprecated
Projects
None yet
Milestone
March 2023 Deprecations
Development

No branches or pull requests
2 participants
@xsawyerx @cromedome