Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dancer2::Core::Error document is obsolete #1669

Closed
xsawyerx opened this issue Aug 9, 2022 · 2 comments
Closed

Dancer2::Core::Error document is obsolete #1669

xsawyerx opened this issue Aug 9, 2022 · 2 comments
Labels
Beginner Suitable Documentation

Comments

@xsawyerx
Copy link
Member

xsawyerx commented Aug 9, 2022

The documentation for Dancer2::Core::Error includes instantiating a new object and then using the render method (which doesn't exist anymore) and then setting it as the response using Dancer2::Core::Response's set, which doesn't exist.

Instead, we just create a new instance and call throw.
@GeekRuthie
Copy link
Contributor

#1680 Addresses this fix.

cromedome pushed a commit that referenced this issue Jul 25, 2023
@GeekRuthie @cromedome
Show correct usage of Dancer2::Core::Error
a24184d 
The documentation for Dancer2::Core::Error includes instantiating a new
object, using the render() method (which doesn't exist anymore), and
then setting the object as the response using Dancer2::Core::Response's
set, which doesn't exist.

Instead, we just create a new instance and call throw.

Closes GH #1669
@cromedome
Copy link
Contributor

Resolved, thanks!

cromedome added a commit that referenced this issue Oct 9, 2023
@cromedome
v1.0.0
ab2a50a 
    [ BUG FIXES ]
    * GH #1663: Allow overriding of prefix in add_route (GeekRuthie)
    * GH #1675: Stringify VERSION_FROM correctly in Makefile.PL (Jason
      A. Crome)
    * GH #1677: Don't deserialize multipart form data on post (Emil
      Perhinschi)
    * GH #1694: Update JS assets in Dancer2 app skel (Jason A. Crome)

    [ ENHANCEMENTS ]
    * PR #1682: Bump minimum version of Perl to 5.14 (Jason A. Crome)

    [ DOCUMENTATION ]
    * GH #1580: Document the purpose of the .dancer file (Jason A. Crome)
    * GH #1669: Show correct usage of Dancer2::Core::Error (GeekRuthie)
    * GH #1674: Fix POD for input_handle() (mauke)
    * GH #1414: Add documentation resources to the doc map (Jason A.
      Crome, Yanick Champoux)
    * PR #1684: Remove shumphrey from core developers (Steven Humphrey)
    * GH #1685: Document the versioning scheme and Dancer2 release
      process (Jason A. Crome)
    * PR #1688: Fixed various bugs/issues in Dancer2 Pod (Jason A. Crome)
    * PR #1691: Update the contribution guidelines (Jason A. Crome)
    * PR #1692: Change README extension .mkdn -> .md (Jason A. Crome)

    [ DEPRECATED ]
    * GH #1645: Deprecated Dancer2::Test (Jason A. Crome)
    * GH #1646: Deprecated keyword: push_header (Jason A. Crome)
    * GH #1647: Deprecated keyword: header (Jason A. Crome)
    * GH #1648: Deprecated keyword: headers (Jason A. Crome)
    * GH #1649: Deprecated keyword: context (Jason A. Crome)
    * GH #1650: Deprecated: splat/capture named placeholders (Jason A.
      Crome)
    * GH #1651: Deprecated core Request instance method:
      request->dispatch_path (Jason A. Crome)
    * GH #1652: Deprecated keyword in plugins: plugin_setting (Jason A.
      Crome)
    * GH #1653: Deprecated keyword in plugins: dancer_app (Jason A. Crome)
    * GH #1654: Deprecated keyword in plugins: request (Jason A. Crome)
    * GH #1655: Deprecated keyword in plugins: var (Jason A. Crome)
    * GH #1656: Deprecated keyword in plugins: hook (Jason A. Crome)

    [ MISC ]
    * GH #1659: Rename `master` branch to be `main` (Yanick Champoux)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Suitable Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xsawyerx @cromedome @GeekRuthie