Update the contribution guidelines #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already covered a lot of ground, and now it covers even more: - Itemize new ways to contribute - Reminds people to run tests - Reasons we may request changes to/reject pull requests A few revisions to language throughout, and in preparation of other upcoming changes, replaced master with main, and fixed some nagging http: links.
GeekRuthie
approved these changes
Aug 30, 2023
xsawyerx
approved these changes
Sep 1, 2023
|
Merged. Thanks for the feedback! |
cromedome
added a commit
that referenced
this pull request
Oct 9, 2023
[ BUG FIXES ]
* GH #1663: Allow overriding of prefix in add_route (GeekRuthie)
* GH #1675: Stringify VERSION_FROM correctly in Makefile.PL (Jason
A. Crome)
* GH #1677: Don't deserialize multipart form data on post (Emil
Perhinschi)
* GH #1694: Update JS assets in Dancer2 app skel (Jason A. Crome)
[ ENHANCEMENTS ]
* PR #1682: Bump minimum version of Perl to 5.14 (Jason A. Crome)
[ DOCUMENTATION ]
* GH #1580: Document the purpose of the .dancer file (Jason A. Crome)
* GH #1669: Show correct usage of Dancer2::Core::Error (GeekRuthie)
* GH #1674: Fix POD for input_handle() (mauke)
* GH #1414: Add documentation resources to the doc map (Jason A.
Crome, Yanick Champoux)
* PR #1684: Remove shumphrey from core developers (Steven Humphrey)
* GH #1685: Document the versioning scheme and Dancer2 release
process (Jason A. Crome)
* PR #1688: Fixed various bugs/issues in Dancer2 Pod (Jason A. Crome)
* PR #1691: Update the contribution guidelines (Jason A. Crome)
* PR #1692: Change README extension .mkdn -> .md (Jason A. Crome)
[ DEPRECATED ]
* GH #1645: Deprecated Dancer2::Test (Jason A. Crome)
* GH #1646: Deprecated keyword: push_header (Jason A. Crome)
* GH #1647: Deprecated keyword: header (Jason A. Crome)
* GH #1648: Deprecated keyword: headers (Jason A. Crome)
* GH #1649: Deprecated keyword: context (Jason A. Crome)
* GH #1650: Deprecated: splat/capture named placeholders (Jason A.
Crome)
* GH #1651: Deprecated core Request instance method:
request->dispatch_path (Jason A. Crome)
* GH #1652: Deprecated keyword in plugins: plugin_setting (Jason A.
Crome)
* GH #1653: Deprecated keyword in plugins: dancer_app (Jason A. Crome)
* GH #1654: Deprecated keyword in plugins: request (Jason A. Crome)
* GH #1655: Deprecated keyword in plugins: var (Jason A. Crome)
* GH #1656: Deprecated keyword in plugins: hook (Jason A. Crome)
[ MISC ]
* GH #1659: Rename `master` branch to be `main` (Yanick Champoux)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already covered a lot of ground, and now it covers even more:
A few revisions to language throughout, and in preparation of other upcoming changes, replaced master with main, and fixed some nagging http: links.