Skip to content

fix(test-scripts/sh): use $0 instead of $_ #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(test-scripts/sh): use $0 instead of $_ #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-scripts/sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env sh

set -e
dir="$(cd "$(dirname "$_")" && pwd)"
dir="$(cd "$(dirname "$0")" && pwd)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good fix. For improved robustness, it's good practice to use -- with dirname to signal the end of options. This prevents dirname from misinterpreting the script path as an option if $0 were to ever begin with a hyphen (-). While this is an unlikely edge case for a script name, it's a good defensive programming habit. I've noticed other scripts in test-scripts/ don't use this; it might be worth considering applying this pattern consistently for better robustness.

dir="$(cd "$(dirname -- "$0")" && pwd)"

script="${dir}/../dist/ColorEcho.sh"
. "${script}"

Expand Down