Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pink-ext: Add api get_public_key! #650

Merged
merged 4 commits into from
Feb 23, 2022
Merged

pink-ext: Add api get_public_key! #650

merged 4 commits into from
Feb 23, 2022

Conversation

kvinwang
Copy link
Collaborator

No description provided.

h4x3rotab
h4x3rotab reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@h4x3rotab h4x3rotab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the API design of:

  1. derive_sr25519_key! for creating the private key
  2. get_public_key! for converting the private key to the corresponding public key

@kvinwang kvinwang changed the title pink-ext: Add api public_key_for pink-ext: Add api get_public_key! Feb 21, 2022
@kvinwang
Copy link
Collaborator Author

I prefer the API design of:

  1. derive_sr25519_key! for creating the private key
  2. get_public_key! for converting the private key to the corresponding public key

Done

h4x3rotab
h4x3rotab approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@h4x3rotab h4x3rotab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from ext-improve to master February 23, 2022 13:05
@kvinwang kvinwang merged commit 0199903 into master Feb 23, 2022
@kvinwang kvinwang deleted the impl-pubkey branch February 23, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h4x3rotab h4x3rotab h4x3rotab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvinwang @h4x3rotab