-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sidevm: Add sidevm:time::maybe_rest() #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API looks like a blackbox to me. Do you think it's better to make an API that allows the caller to decide the percentage of the remaining gas like this: yield_under_threashold(0.3)
? We can make an API with the default value 30% on the guest side.
I think it's a bit confusing to the caller on how to set the threshold. The BTW, I didn't choose the name |
OK. Then how about |
Sounds OK to me. iOS guys would prefer the verbose one.😄 |
Guest code can call this API regularly to avoid being stifled.