Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7/8 compatibility fixes #1043

Closed
wants to merge 1 commit into from
Closed

PHP 7/8 compatibility fixes #1043

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2021

No description provided.

@@ -0,0 +1,54 @@
<?php
// MIT License
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this license compatible with phorum/core to be bundled?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phorum license is based on The Apache Software License Version 1.1. Both licenses are permissive, non-copyleft. So I think it's okay. Some explanation.

@Neustradamus
Copy link

Have you progressed on it?

@ghost
Copy link
Author

ghost commented Mar 16, 2022

It would be more appropriate to make this repository a public archive. Obviously, there will be no more development here.

@ghost ghost closed this Mar 16, 2022
@brianlmoon
Copy link
Member

@s2k0z Do you want access to this repository? That could happen if you would like to make changes here.

@brianlmoon
Copy link
Member

Personally, I keep having the urge to start from scratch on the code. heh. I just can't find the time.

@Neustradamus
Copy link

@brianlmoon: Thanks for your messages, I think it is needed to have a new dev team...

@oricgn
Copy link
Contributor

oricgn commented Mar 18, 2022

I would like to assist the new dev team but I'm not familiar with actual PHP programming styles.

@ghost
Copy link
Author

ghost commented Mar 19, 2022

@s2k0z Do you want access to this repository? That could happen if you would like to make changes here.

If there are still people who need a maintenance release, I want to do it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants