Remove element's child nodes when empty dataset is bound as a list (#125

)

* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Add failing test for #124

* Empty element's child nodes when binding empty dataset
Closes #124

src/Bindable.php

@@ -95,6 +95,10 @@ public function bindList(
 		string $templateName = null
 	):int {
 		if(empty($kvpList)) {
+			if($this->children->length === 0) {
+				$this->innerHTML = "";
+			}
+
 			return 0;
 		}
 

test/unit/BindableTest.php

@@ -621,7 +621,7 @@ public function testTemplateNameIsAddedWhenNamed() {
 
 		foreach(["one", "two", "three"] as $num) {
 			$t = $document->getTemplate("list-item");
-			$t->innerText = $num;
+			$t->innerHTML = $num;
 			$inserted = $t->insertTemplate();
 
 			self::assertStringContainsString("t-list-item", $inserted->getAttribute("class"));
@@ -651,4 +651,12 @@ public function testBindKeyValueBool() {
 		self::assertFalse($listItems[0]->classList->contains("completed"));
 		self::assertTrue($listItems[1]->classList->contains("completed"));
 	}
+
+	public function testBindListEmptySetsInnerHtmlToEmpty() {
+		$document = new HTMLDocument(Helper::HTML_TODO_LIST);
+		$document->extractTemplates();
+		$ul = $document->getElementById("todo-list");
+		$ul->bindList([]);
+		self::assertEquals("", $ul->innerHTML);
+	}
 }