Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindDataMap return type #88

Closed
g105b opened this issue Sep 11, 2019 · 0 comments
Closed

bindDataMap return type #88

g105b opened this issue Sep 11, 2019 · 0 comments
Milestone
v2

Comments

@g105b
Copy link
Member

g105b commented Sep 11, 2019

Return type could be an iterator, not just an array. This is according to the WebEngine documentation.
@g105b g105b added this to the v2 milestone Sep 12, 2019
g105b added a commit that referenced this issue Sep 18, 2019
@g105b
Allow returning any iterable, not just array - fixes #88
798cdb5
@g105b g105b closed this as completed in 4f38cd4 Sep 18, 2019
g105b added a commit that referenced this issue Sep 19, 2019
@g105b
implicit-bind-data (#96)
14b91d9 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Implicit binding on bindData
g105b added a commit that referenced this issue Oct 21, 2019
@g105b
Test multiple parameters binding (#100)
dde338b 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Rename tests

* Isolate and fix bug binding multiple parameter placeholders
g105b added a commit that referenced this issue Nov 25, 2019
@g105b
Only output t- prefix when there is a named template (#109)
5515ea4 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Tidy binding non-iterable data

* Only output t- prefix on named templates

* Update to dom v2.1.5
g105b added a commit that referenced this issue Nov 27, 2019
@g105b
Simplify the mechanisms behind bind* functions. (#111)
7468beb 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Isolate bug for #105 - use README example

* Rename BindDataGetter -> BindObject

* Tidy up bindData function

* Test incompatible bindData types

* Remove bindNestedList function

* Testing bindValue

* Test bindObjectValue

* Test bindValue within lists

* Bindable type checking

* Simplify bind functions, closes #110

* Skip empty lists
g105b added a commit that referenced this issue Nov 28, 2019
@g105b
Nullable lists (#114)
a36aa7e 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Treat nullable iterable as empty list

* Update dependencies
g105b added a commit that referenced this issue Dec 11, 2019
@g105b
Fix for #105 (#121)
fcccb78 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Remove unused functions

* Extract templates after expanding components. Closes #105
g105b added a commit that referenced this issue Jan 15, 2020
@g105b
Remove element's child nodes when empty dataset is bound as a list (#125
ec45af4 
)

* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Add failing test for #124

* Empty element's child nodes when binding empty dataset
Closes #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@g105b