Efficiency of bindList with many items #77

g105b · 2019-08-01T14:18:32Z

Rather than cloning the template element for each iteration, create a fragment to output to, then append the fragment to the page.

Appending to the DOM is a relatively costly function, but appending to a fragment is not.

for #77

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Improvements to efficiency * Only attempt to append fragment if template parent exists * Only bind parameters that are market for binding * Update deps * Test data-bind-parameters usage

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Add test for #84 * Implement boolean attribute binding closes #84

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Return number of iterations * Quick implementation, closes #90. Wraps existing functionality. Requires refactoring to include all functionality within bindList * Update dependencies

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Implement and test bind* function with get* kept for compatibility Closes #89

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Implicit binding on bindData

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Test that multiple kvps can be bound within the same parameter * Rename tests * Isolate and fix bug binding multiple parameter placeholders

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Test that multiple kvps can be bound within the same parameter * Tidy binding non-iterable data * Only output t- prefix on named templates * Update to dom v2.1.5

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Test that multiple kvps can be bound within the same parameter * Isolate bug for #105 - use README example * Rename BindDataGetter -> BindObject * Tidy up bindData function * Test incompatible bindData types * Remove bindNestedList function * Testing bindValue * Test bindObjectValue * Test bindValue within lists * Bindable type checking * Simplify bind functions, closes #110 * Skip empty lists

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Test that multiple kvps can be bound within the same parameter * Treat nullable iterable as empty list * Update dependencies

* Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Test that multiple kvps can be bound within the same parameter * Remove unused functions * Extract templates after expanding components. Closes #105

) * Fix return type for getElementById, closes #65 * Update PHPDoc to include inherited changes * Rename function for removing template attributes * Set value for certain input fields differently * Bind list to document fragment for efficiency for #77 * Remove unbindable check * Allow returning any iterable, not just array - fixes #88 * Test that multiple kvps can be bound within the same parameter * Add failing test for #124 * Empty element's child nodes when binding empty dataset Closes #124

g105b added the enhancement label Aug 1, 2019

g105b added a commit that referenced this issue Aug 5, 2019

Bind list to document fragment for efficiency

494fd61

for #77

g105b closed this as completed Aug 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Efficiency of bindList with many items #77

Efficiency of bindList with many items #77

g105b commented Aug 1, 2019

Efficiency of bindList with many items #77

Efficiency of bindList with many items #77

Comments

g105b commented Aug 1, 2019